From: Peter Maydell <peter.maydell@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: Eric Auger <eric.auger@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4 6/6] hw/arm/virt: Implement kvm-steal-time
Date: Thu, 8 Oct 2020 21:39:59 +0100 [thread overview]
Message-ID: <CAFEAcA-ZwwzrjPjsaGJbwW-y0g+j-usk25f1hiFVadaS74Nv+w@mail.gmail.com> (raw)
In-Reply-To: <20201001061718.101915-7-drjones@redhat.com>
On Thu, 1 Oct 2020 at 07:17, Andrew Jones <drjones@redhat.com> wrote:
>
> We add the kvm-steal-time CPU property and implement it for machvirt.
> A tiny bit of refactoring was also done to allow pmu and pvtime to
> use the same vcpu device helper functions.
> + if (pvtime_size > pvtime_reg_size) {
> + error_report("pvtime requires a %ld byte memory region for "
> + "%d CPUs, but only %ld has been reserved",
> + pvtime_size, max_cpus, pvtime_reg_size);
> + exit(1);
> + }
This turns out not to compile on Windows:
../../hw/arm/virt.c:1693:30: error: format '%ld' expects argument of
type 'long int', but argument 2 has type 'hwaddr {aka long long
unsigned int}' [-Werror=format=]
error_report("pvtime requires a %ld byte memory region for "
^
I'm going to squash this fix into the pullreq:
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1690,8 +1690,9 @@ static void virt_cpu_post_init(VirtMachineState
*vms, int max_cpus,
pvtime_size = REAL_HOST_PAGE_ALIGN(pvtime_size);
if (pvtime_size > pvtime_reg_size) {
- error_report("pvtime requires a %ld byte memory region for "
- "%d CPUs, but only %ld has been reserved",
+ error_report("pvtime requires a %" HWADDR_PRId
+ " byte memory region for %d CPUs,"
+ " but only %" HWADDR_PRId " has been reserved",
pvtime_size, max_cpus, pvtime_reg_size);
exit(1);
}
thanks
-- PMM
next prev parent reply other threads:[~2020-10-08 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 6:17 [PATCH v4 0/6] hw/arm/virt: Introduce kvm-steal-time Andrew Jones
2020-10-01 6:17 ` [PATCH v4 1/6] linux headers: sync to 5.9-rc7 Andrew Jones
2020-10-01 6:17 ` [PATCH v4 2/6] target/arm/kvm: Make uncalled stubs explicitly unreachable Andrew Jones
2020-10-01 6:17 ` [PATCH v4 3/6] hw/arm/virt: Move post cpu realize check into its own function Andrew Jones
2020-10-01 6:17 ` [PATCH v4 4/6] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init Andrew Jones
2020-10-01 6:17 ` [PATCH v4 5/6] tests/qtest: Restore aarch64 arm-cpu-features test Andrew Jones
2020-10-01 6:17 ` [PATCH v4 6/6] hw/arm/virt: Implement kvm-steal-time Andrew Jones
2020-10-08 20:39 ` Peter Maydell [this message]
2020-10-08 21:12 ` Andrew Jones
2020-10-08 13:01 ` [PATCH v4 0/6] hw/arm/virt: Introduce kvm-steal-time Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-ZwwzrjPjsaGJbwW-y0g+j-usk25f1hiFVadaS74Nv+w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.