From: Peter Maydell <peter.maydell@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PULL 07/13] msix: fix msix_vector_masked
Date: Fri, 19 Feb 2016 12:20:23 +0000 [thread overview]
Message-ID: <CAFEAcA-cfNnruJmQVgRcYqKw0AqPwqO=Ucue-0j=9Ek-uEwZCQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1602191217590.30088@kaball.uk.xensource.com>
On 19 February 2016 at 12:18, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
> On Fri, 19 Feb 2016, Michael S. Tsirkin wrote:
>> commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on Xen")
>> inadvertently enabled the xen-specific logic unconditionally.
>> Limit it to only when xen is enabled.
>> Additionally, msix data should be read with pci_get_log
>> since the format is pci little-endian.
>>
>> Reported-by: "Daniel P. Berrange" <berrange@redhat.com>
>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> the follow up patch is missing from the pull request:
>
> http://marc.info/?l=xen-devel&m=145553838801725&w=2
does this mean I should prefer not to apply the pull, or can
that patch be committed later ?
thanks
-- PMM
next prev parent reply other threads:[~2016-02-19 12:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 8:00 [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 01/13] virtio-net: use the backend cross-endian capabilities Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 02/13] vhost-net: revert support of cross-endian vnet headers Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 03/13] virtio: move cross-endian helper to vhost Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 04/13] vhost: move virtio 1.0 check to cross-endian helper Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 05/13] vhost: simplify vhost_needs_vring_endian() Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 06/13] virtio: optimize virtio_access_is_big_endian() for little-endian targets Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 07/13] msix: fix msix_vector_masked Michael S. Tsirkin
2016-02-19 12:18 ` Stefano Stabellini
2016-02-19 12:20 ` Peter Maydell [this message]
2016-02-19 12:29 ` Stefano Stabellini
2016-02-19 8:00 ` [Qemu-devel] [PULL 08/13] tests: add pxe e1000 and virtio-pci tests Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 09/13] dec: convert to realize() Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 10/13] change type of pci_bridge_initfn() to void Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 11/13] rules: filter out irrelevant files Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 12/13] vhost-user interrupt management fixes Michael S. Tsirkin
2016-02-19 8:00 ` [Qemu-devel] [PULL 13/13] tests/vhost-user-bridge: add scattering of incoming packets Michael S. Tsirkin
2016-02-19 12:09 ` [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe Peter Maydell
2016-02-19 12:41 ` Samuel Thibault
2016-02-19 14:17 ` Peter Maydell
2016-03-23 0:05 ` Samuel Thibault
2016-03-23 12:43 ` Peter Maydell
2016-03-23 12:45 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-cfNnruJmQVgRcYqKw0AqPwqO=Ucue-0j=9Ek-uEwZCQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.