Re: [Qemu-devel] [PULL 00/15] tb hash improvements

From: Peter Maydell <peter.maydell@linaro.org>
To: "Emilio G. Cota" <cota@braap.org>
Cc: Richard Henderson <rth@twiddle.net>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/15] tb hash improvements
Date: Fri, 10 Jun 2016 17:41:26 +0100	[thread overview]
Message-ID: <CAFEAcA8ALC0i250JFBWn0G-ZwyaryrKTR6r=ixscngbrjT7M3w@mail.gmail.com> (raw)
In-Reply-To: <20160610163432.GA22231@flamenco>

On 10 June 2016 at 17:34, Emilio G. Cota <cota@braap.org> wrote:
> On Fri, Jun 10, 2016 at 16:33:10 +0100, Peter Maydell wrote:
>> Fails to build on ppc64be :-(
>>
>> In file included from /home/pm215/qemu/include/qemu/thread.h:4:0,
>>                  from /home/pm215/qemu/include/block/aio.h:20,
>>                  from /home/pm215/qemu/include/block/block.h:4,
>>                  from /home/pm215/qemu/include/monitor/monitor.h:6,
>>                  from /home/pm215/qemu/trace/control.c:23:
>> /home/pm215/qemu/include/qemu/processor.h:24:35: error: expected
>> identifier or ‘(’ before string constant
>>                                    "or 2, 2, 2;" ::: "memory")
>
> On Fri, Jun 10, 2016 at 16:57:19 +0100, Peter Maydell wrote:
>> Also fails trying to build a test on 32-bit:
>>
>> /home/petmay01/qemu/tests/qht-bench.c: In function 'pr_params':
>> /home/petmay01/qemu/tests/qht-bench.c:270:5: error: format '%zu'
>> expects argument of type 'size_t', but argument 2 has type 'long
>> unsigned int' [-Werror=format=]
>>      printf(" lookup range:      %zu\n", lookup_range);
>
> Can you please test again after applying the appended delta?

I will test.

For the PPC asm, is it not just wanting the "\n" between instructions?
Shouldn't be necessary to use two separate asm() lines...

thanks
-- PMM