Re: [PATCH for 9.1 v2 1/2] buildsys: Bump known good meson version to v1.4.0

From: Peter Maydell <peter.maydell@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Beraldo Leal" <bleal@redhat.com>,
	qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>, "John Snow" <jsnow@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>
Subject: Re: [PATCH for 9.1 v2 1/2] buildsys: Bump known good meson version to v1.4.0
Date: Tue, 26 Mar 2024 12:40:16 +0000	[thread overview]
Message-ID: <CAFEAcA8JF35A5o-+F39sXFnkTDnPo29A7zCZgxFPt3388sVvig@mail.gmail.com> (raw)
In-Reply-To: <20240326-meson-v2-1-d9f9003775e9@daynix.com>

On Tue, 26 Mar 2024 at 12:35, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> We need meson v1.4.0 to fix MESONINTROSPECT quoting on Windows:
> https://github.com/mesonbuild/meson/pull/12807
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  python/scripts/vendor.py                   |   4 ++--
>  python/wheels/meson-1.2.3-py3-none-any.whl | Bin 964928 -> 0 bytes
>  python/wheels/meson-1.4.0-py3-none-any.whl | Bin 0 -> 935471 bytes
>  pythondeps.toml                            |   2 +-
>  4 files changed, 3 insertions(+), 3 deletions(-)

> --- a/pythondeps.toml
> +++ b/pythondeps.toml
> @@ -19,7 +19,7 @@
>
>  [meson]
>  # The install key should match the version in python/wheels/
> -meson = { accepted = ">=0.63.0", installed = "1.2.3", canary = "meson" }
> +meson = { accepted = ">=0.63.0", installed = "1.4.0", canary = "meson" }

If we need 1.4.0 why does this still say we accept anything 0.63.0
or better ?

If we use shlex.split(), does that go wrong for pre-1.4.0
meson only on Windows, or is it broken for all platforms?
(i.e. could we if we wanted to make the requirement
"1.4.0 for windows, 0.63.0 for others"?)

thanks
-- PMM