From: Peter Maydell <peter.maydell@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: Re: [PATCH] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu
Date: Mon, 25 Jul 2022 15:43:45 +0100 [thread overview]
Message-ID: <CAFEAcA8d0A8ns1uMtOTaKr+QvYB+XunGNtOuGTbhRFqmPHh7Gw@mail.gmail.com> (raw)
In-Reply-To: <20220725142854.177451-1-iii@linux.ibm.com>
On Mon, 25 Jul 2022 at 15:32, Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>
> When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored.
> Fix by using qemu_fprintf() instead of qemu_printf() in the respective
> places.
>
> Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Looks like sh4 was the only target where 90c84c560067 introduced this bug.
thanks
-- PMM
next prev parent reply other threads:[~2022-07-25 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 14:28 [PATCH] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu Ilya Leoshkevich
2022-07-25 14:43 ` Peter Maydell [this message]
2022-07-27 2:09 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8d0A8ns1uMtOTaKr+QvYB+XunGNtOuGTbhRFqmPHh7Gw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.