Re: [Qemu-devel] [PATCH v7 2/2] Add Nios II semihosting support.

From: Peter Maydell <peter.maydell@linaro.org>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Chris Wulff <crwulff@gmail.com>, Marek Vasut <marex@denx.de>
Subject: Re: [Qemu-devel] [PATCH v7 2/2] Add Nios II semihosting support.
Date: Thu, 4 Apr 2019 14:18:08 +0700	[thread overview]
Message-ID: <CAFEAcA8g0qQadBjiOU9P_BRNiXJx0WPp11Y0qRmoO-jGDbMteA@mail.gmail.com> (raw)
In-Reply-To: <5a4d38da-3ccc-b019-3f30-54cd364f7544@codesourcery.com>

On Thu, 4 Apr 2019 at 14:13, Sandra Loosemore <sandra@codesourcery.com> wrote:
>
> On 4/4/19 1:00 AM, Peter Maydell wrote:
> > On Thu, 4 Apr 2019 at 13:44, Sandra Loosemore <sandra@codesourcery.com> wrote:
> >>
> >> On 4/3/19 11:59 PM, Peter Maydell wrote:
> >>> On Thu, 4 Apr 2019 at 02:53, Sandra Loosemore <sandra@codesourcery.com> wrote:
> >>>>
> >>>> This patch adds support for libgloss semihosting to Nios II bare-metal
> >>>> emulation.  The specification for the protocol can be found in the
> >>>> libgloss sources.
> >>>>
> >>>> Signed-off-by: Sandra Loosemore <sandra@codesourcery.com>
> >>>> Signed-off-by: Julian Brown <julian@codesourcery.com>
> >>>
> >>> I gave a reviewed-by tag for this patch in v6 -- has something changed
> >>> in v7 that made that no longer able to carry across?
> >>
> >> I fixed the formatting problems you asked me to address.  What else am I
> >> supposed to do?  I don't understand what you mean about the tag.
> >
> > If somebody provides you with a Reviewed-by tag and you submit
> > a fresh version of the patchset then you should include that tag in
> > your commit message; that records that the patch has been reviewed
> > so that people know it doesn't need to be looked at again.
> > https://wiki.qemu.org/Contribute/SubmitAPatch#Proper_use_of_Reviewed-by:_tags_can_aid_review
>
> Hmmm, OK; I missed that.  So do I need to resubmit the patches just to
> add that tag?

No, not at this point. I'll just add one here:
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

which should cause the automated tooling to pick it up when
it gets applied to somebody's tree for a pullreq.

thanks
-- PMM