Re: [Qemu-devel] [PATCH v4 4/4] hw/arm: versal: Add a virtual Xilinx Versal board

From: Peter Maydell <peter.maydell@linaro.org>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"KONRAD Frederic" <frederic.konrad@adacore.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Francisco Iglesias" <frasse.iglesias@gmail.com>,
	figlesia@xilinx.com,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Sai Pavan Boddu" <sai.pavan.boddu@xilinx.com>,
	"Edgar Iglesias" <edgar.iglesias@xilinx.com>
Subject: Re: [Qemu-devel] [PATCH v4 4/4] hw/arm: versal: Add a virtual Xilinx Versal board
Date: Tue, 30 Oct 2018 13:31:44 +0000	[thread overview]
Message-ID: <CAFEAcA_BGhqMiQGgF3TSXBXHacQf31emVTZv2tcr0Qo77bKcvA@mail.gmail.com> (raw)
In-Reply-To: <20181022173559.17111-5-edgar.iglesias@gmail.com>

On 22 October 2018 at 18:35, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Add a virtual Xilinx Versal board.
>
> This board is based on the Xilinx Versal SoC. The exact
> details of what peripherals are attached to this board
> will remain in control of QEMU. QEMU will generate an
> FDT on the fly for Linux and other software to auto-discover
> peripherals.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

> +static void fdt_add_fixed_link_nodes(VersalVirt *s, char *gemname,
> +                                     uint32_t phandle)
> +{
> +    char *name = g_strdup_printf("%s/fixed-link", gemname);
> +
> +    qemu_fdt_add_subnode(s->fdt, name);
> +    qemu_fdt_setprop_cell(s->fdt, name, "phandle", phandle);
> +    qemu_fdt_setprop_cells(s->fdt, name, "full-duplex");

Hi. This fails to compile in a non-debug build:

In file included from /home/peter.maydell/qemu/hw/arm/xlnx-versal-virt.c:16:0:
/home/peter.maydell/qemu/hw/arm/xlnx-versal-virt.c: In function
'fdt_add_fixed_link_nodes':
/home/peter.maydell/qemu/include/sysemu/device_tree.h:110:23: error:
comparison of unsigned expression < 0 is always false
[-Werror=type-limits]
         for (i = 0; i < ARRAY_SIZE(qdt_tmp); i++) {                           \
                       ^
/home/peter.maydell/qemu/hw/arm/xlnx-versal-virt.c:191:5: note: in
expansion of macro 'qemu_fdt_setprop_cells'
     qemu_fdt_setprop_cells(s->fdt, name, "full-duplex");
     ^

because qemu_fdt_setprop_cells() requires you to provide
at least one cell value for the property being set.
What was the intention here ?

> +    qemu_fdt_setprop_cell(s->fdt, name, "speed", 1000);
> +    g_free(name);
> +}

In the meantime, I'm dropping the versal patches from
target-arm.next.

thanks
-- PMM