Re: [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt()

From: Ley Foon Tan <lftan@altera.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	Rocketboard Maillist <rfi@lists.rocketboards.org>,
	linux-pci <linux-pci@vger.kernel.org>
Subject: Re: [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt()
Date: Tue, 18 Oct 2016 10:22:30 +0800	[thread overview]
Message-ID: <CAFiDJ5_K0wK6QH6=adSDm_2PbqnyaVWCyJZtX3DPSZQkHd-QKg@mail.gmail.com> (raw)
In-Reply-To: <1476716173-31310-1-git-send-email-weiyj.lk@gmail.com>

On Mon, Oct 17, 2016 at 10:56 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/pci/host/pcie-altera.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
> index b0ac4df..8be45a8 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -550,10 +550,8 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
>
>         cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
>         pcie->cra_base = devm_ioremap_resource(dev, cra);
> -       if (IS_ERR(pcie->cra_base)) {
> -               dev_err(dev, "failed to map cra memory\n");
> +       if (IS_ERR(pcie->cra_base))
>                 return PTR_ERR(pcie->cra_base);
> -       }
>
>         /* setup IRQ */
>         pcie->irq = platform_get_irq(pdev, 0);
>
Acked-by: Ley Foon Tan <lftan@altera.com>