Re: [PATCH v2 3/3] lbespol: remove wild cards in mapfile

From: Ondrej Mosnacek <omosnace@redhat.com>
To: William Roberts <bill.c.roberts@gmail.com>
Cc: Stephen Smalley <stephen.smalley.work@gmail.com>,
	Nicolas Iooss <nicolas.iooss@m4x.org>,
	SElinux list <selinux@vger.kernel.org>,
	Ulrich Drepper <drepper@redhat.com>,
	Petr Lautrbach <plautrba@redhat.com>,
	William Roberts <william.c.roberts@intel.com>
Subject: Re: [PATCH v2 3/3] lbespol: remove wild cards in mapfile
Date: Fri, 13 Mar 2020 15:41:11 +0100	[thread overview]
Message-ID: <CAFqZXNu=gPM=HE7M0tgb_Bba+ih+ZSedrj=7P06i8Q7nu+KtLQ@mail.gmail.com> (raw)
In-Reply-To: <CAFftDdpUP9BVFxZrY_ZNs2276OGuwKQaRJo_DvVLqjo073Mj1A@mail.gmail.com>

On Fri, Mar 13, 2020 at 3:23 PM William Roberts
<bill.c.roberts@gmail.com> wrote:
> On Fri, Mar 13, 2020 at 6:03 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > On Thu, Mar 12, 2020 at 10:42 PM William Roberts
> > <bill.c.roberts@gmail.com> wrote:
> > > On Thu, Mar 12, 2020 at 3:21 PM Stephen Smalley
> > > <stephen.smalley.work@gmail.com> wrote:
> > > >
> > > > On Thu, Mar 12, 2020 at 9:59 AM William Roberts
> > > > <bill.c.roberts@gmail.com> wrote:
> > > > >
> > > > > I will fix the subject and add the Fixes: #165 to the commit when I
> > > > > stage them if thats ok?
> > > >
> > > > Fixes both 165 and 204 IIUC because the real underlying issue for both was the
> > > > fact that he was building with LTO and it was doing the wrong thing
> > > > with hidden_def/hidden_proto.
> > > > Otherwise works for me.  You can download the series from patchwork or
> > > > via get-lore-mbox
> > > > to pick up all the Acks automatically.
> > >
> > > I have no idea how to do that, Ill have to spend some time and
> > > familiarize myself with it.
> >
> > You can simply go to
> > https://patchwork.kernel.org/project/selinux/list/, click on any patch
> > in the series (e.g. https://patchwork.kernel.org/patch/11430261/) and
> > copy the address of the "series" button/link in the upper right
> > corner. Then you just do:
> >
> > curl <link> | git am
> >
> > There is certainly a faster way to do it using the Patchwork CLI, but
> > I never bothered to set that up :)
>
> Thanks, ill have to try that next time!
>
> >
> > > For now I just manually added the acks and did the edits we discussed
> > > and rebased ontop
> > > of current master. Their was a simple conflict in libsepol/src/services.c.
> > >
> > > I have them staged here:
> > > https://github.com/SELinuxProject/selinux/pull/207
> >
> > The CI failed because libsepol/src/services.c still includes "dso.h"
> > in the rebased commits. You'll need to fix that first.
>
> I'm sitting here thinking, "I built and ran the tests, how?" Looking
> at bash history,
> for libselinux, not libsepol!

No worries, fortunately we have CI to cover our backs :)

Anyway, I just noticed that there is still a typo in the last commit's
title ("libespol").

-- 
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.