From: Ondrej Mosnacek <omosnace@redhat.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, selinux@vger.kernel.org,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Linux Security Module list
<linux-security-module@vger.kernel.org>,
Casey Schaufler <casey@schaufler-ca.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v4 3/5] LSM: add new hook for kernfs node initialization
Date: Tue, 5 Feb 2019 12:10:33 +0100 [thread overview]
Message-ID: <CAFqZXNveDL23r8Q3sQ_FM_bK6R157z0x=BjxQ4vS8rT+bW45PQ@mail.gmail.com> (raw)
In-Reply-To: <201902051753.YakI70it%fengguang.wu@intel.com>
On Tue, Feb 5, 2019 at 10:52 AM kbuild test robot <lkp@intel.com> wrote:
>
> Hi Ondrej,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on driver-core/driver-core-testing]
> [also build test ERROR on v5.0-rc4 next-20190205]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Ondrej-Mosnacek/Allow-initializing-the-kernfs-node-s-secctx-based-on-its-parent/20190205-171434
> config: x86_64-randconfig-x013-201905 (attached as .config)
> compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> In file included from fs/file_table.c:15:
> >> include/linux/security.h:796:1: error: expected identifier or '(' before '{' token
> {
> ^
> In file included from fs/file_table.c:15:
> include/linux/security.h:792:19: warning: 'security_kernfs_init_security' declared 'static' but never defined [-Wunused-function]
> static inline int security_kernfs_init_security(
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> vim +796 include/linux/security.h
>
> 791
> 792 static inline int security_kernfs_init_security(
> 793 const struct qstr *qstr, const struct iattr *dir_iattr,
> 794 struct simple_xattrs *dir_secattr, const struct iattr *iattr,
> 795 struct simple_xattrs *secattr);
> > 796 {
> 797 return 0;
> 798 }
> 799
*facepalm*... Fixed in v5.
--
Ondrej Mosnacek <omosnace at redhat dot com>
Associate Software Engineer, Security Technologies
Red Hat, Inc.
next prev parent reply other threads:[~2019-02-05 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 8:59 [PATCH v4 0/5] Allow initializing the kernfs node's secctx based on its parent Ondrej Mosnacek
2019-02-05 8:59 ` [PATCH v4 1/5] selinux: try security xattr after genfs for kernfs filesystems Ondrej Mosnacek
2019-02-05 8:59 ` [PATCH v4 2/5] kernfs: use simple_xattrs for security attributes Ondrej Mosnacek
2019-02-05 8:59 ` [PATCH v4 3/5] LSM: add new hook for kernfs node initialization Ondrej Mosnacek
2019-02-05 9:51 ` kbuild test robot
2019-02-05 11:10 ` Ondrej Mosnacek [this message]
2019-02-05 10:25 ` kbuild test robot
2019-02-05 8:59 ` [PATCH v4 4/5] selinux: implement the kernfs_init_security hook Ondrej Mosnacek
2019-02-05 8:59 ` [PATCH v4 5/5] kernfs: initialize security of newly created nodes Ondrej Mosnacek
2019-02-05 10:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqZXNveDL23r8Q3sQ_FM_bK6R157z0x=BjxQ4vS8rT+bW45PQ@mail.gmail.com' \
--to=omosnace@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=cgroups@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.