Re: [PATCH] Adds a new ioctl32 syscall for backwards compatibility layers

From: Souptick Joarder <jrdr.linux@gmail.com>
To: kernel test robot <lkp@intel.com>
Cc: sonicadvance1@gmail.com, kbuild-all@lists.01.org,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 Alexander Viro <viro@zeniv.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	 Christian Brauner <christian.brauner@ubuntu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Linux Memory Management List <linux-mm@kvack.org>,
	Minchan Kim <minchan@kernel.org>,
	 Aleksa Sarai <cyphar@cyphar.com>
Subject: Re: [PATCH] Adds a new ioctl32 syscall for backwards compatibility layers
Date: Sat, 9 Jan 2021 10:20:15 +0530	[thread overview]
Message-ID: <CAFqt6zaGOySBGNXybm-qpp22BOrfo5MZv31qDzXoE4J-RnGaUg@mail.gmail.com> (raw)
In-Reply-To: <202101061653.5TRW1DBX-lkp@intel.com>

On Wed, Jan 6, 2021 at 1:39 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v5.11-rc2]
> [cannot apply to arm64/for-next/core asm-generic/master soc/for-next next-20210104]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:    https://github.com/0day-ci/linux/commits/sonicadvance1-gmail-com/Adds-a-new-ioctl32-syscall-for-backwards-compatibility-layers/20210106-145354
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
> config: arc-randconfig-r005-20210106 (attached as .config)
> compiler: arc-elf-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/a927032b3a499474d8484f47644aa9a2578a5196
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review sonicadvance1-gmail-com/Adds-a-new-ioctl32-syscall-for-backwards-compatibility-layers/20210106-145354
>         git checkout a927032b3a499474d8484f47644aa9a2578a5196
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    In file included from kernel/events/core.c:34:
> >> include/linux/syscalls.h:390:5: error: unknown type name 'compat_ulong_t'
>      390 |     compat_ulong_t arg);
>          |     ^~~~~~~~~~~~~~
>    kernel/events/core.c:6535:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
>     6535 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
>          |      ^~~~~~~~~~~~~~~~~~~~~
>    In file included from include/linux/perf_event.h:25,
>                     from include/linux/trace_events.h:10,
>                     from include/trace/syscall.h:7,
>                     from include/linux/syscalls.h:84,
>                     from kernel/events/core.c:34:
>    arch/arc/include/asm/perf_event.h:126:23: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=]
>      126 | static const unsigned arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
>          |                       ^~~~~~~~~~~~~~~~~
>    arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=]
>       91 | static const char * const arc_pmu_ev_hw_map[] = {
>          |                           ^~~~~~~~~~~~~~~~~
>

These two variables arc_pmu_cache_map & arc_pmu_ev_hw_map are used in
arch/arc/kernel/perf_event.c. I think, moving it some other  files/header will
silence these warnings.

>
> vim +/compat_ulong_t +390 include/linux/syscalls.h
>
>    385
>    386  /* fs/ioctl.c */
>    387  asmlinkage long sys_ioctl(unsigned int fd, unsigned int cmd,
>    388                                  unsigned long arg);
>    389  asmlinkage long sys_ioctl32(unsigned int fd, unsigned int cmd,
>  > 390                                  compat_ulong_t arg);
>    391
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org