From: Julian Calaby <julian.calaby@gmail.com>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Paul Stewart <pstew@chromium.org>,
Doug Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org,
Arend van Spriel <arend@broadcom.com>,
Pieter-Paul Giesberts <pieterpg@broadcom.com>,
brcm80211-dev-list@broadcom.com,
linux-wireless <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hante Meuleman <meuleman@broadcom.com>,
Brett Rudley <brudley@broadcom.com>,
netdev <netdev@vger.kernel.org>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>
Subject: Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit
Date: Mon, 25 Jan 2016 22:06:35 +1100 [thread overview]
Message-ID: <CAGRGNgXWE=b52Mcy8NsKBZS_4gz-TUiuFipjsuTZh1xjja=uUg@mail.gmail.com> (raw)
In-Reply-To: <1453718849-3508-1-git-send-email-sjoerd.simons@collabora.co.uk>
Hi Sjoerd,
On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons
<sjoerd.simons@collabora.co.uk> wrote:
> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems
> the card responds very quickly most of the time, unfortunately during
> initialisation it sometimes seems to take just a bit over 2 seconds to
> respond.
>
> This results intialization failing with message like:
> brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52
> brcmf_bus_start: failed: -52
> brcmf_sdio_firmware_callback: dongle is not responding
>
> Increasing the timeout to allow for a bit more headroom allows the
> card to initialize reliably.
>
> A quick search online after diagnosing/fixing this showed that Google
> has a similar patch in their ChromeOS tree, so this doesn't seem
> specific to the board I'm using.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Looks sane to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> index dd66143..75ac4bd 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> @@ -45,8 +45,8 @@
> #include "chip.h"
> #include "firmware.h"
>
> -#define DCMD_RESP_TIMEOUT msecs_to_jiffies(2000)
> -#define CTL_DONE_TIMEOUT msecs_to_jiffies(2000)
> +#define DCMD_RESP_TIMEOUT msecs_to_jiffies(2500)
> +#define CTL_DONE_TIMEOUT msecs_to_jiffies(2500)
>
> #ifdef DEBUG
>
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
next prev parent reply other threads:[~2016-01-25 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:47 [PATCH] brcmfmac: sdio: Increase the default timeouts a bit Sjoerd Simons
2016-01-25 11:06 ` Julian Calaby [this message]
2016-01-25 15:39 ` Arend van Spriel
2016-01-25 15:39 ` Arend van Spriel
2016-01-25 23:41 ` Julian Calaby
2016-01-26 6:29 ` Arend van Spriel
2016-01-25 15:36 ` Arend van Spriel
2016-01-25 15:55 ` Sjoerd Simons
2016-01-25 19:23 ` Doug Anderson
2016-01-25 20:07 ` Arend van Spriel
2016-01-25 20:07 ` Arend van Spriel
2016-01-25 20:32 ` Doug Anderson
2016-01-25 20:32 ` Doug Anderson
2016-01-26 9:12 ` Sjoerd Simons
2016-01-26 9:12 ` Sjoerd Simons
2016-01-26 9:12 ` Sjoerd Simons
2016-02-06 11:59 ` Kalle Valo
[not found] ` <1453718849-3508-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2016-02-06 11:59 ` Kalle Valo
2016-02-06 11:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRGNgXWE=b52Mcy8NsKBZS_4gz-TUiuFipjsuTZh1xjja=uUg@mail.gmail.com' \
--to=julian.calaby@gmail.com \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=dianders@chromium.org \
--cc=frankyl@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
--cc=pstew@chromium.org \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.