From: Daniel Latypov <dlatypov@google.com>
To: SeongJae Park <sj@kernel.org>
Cc: brendanhiggins@google.com, davidgow@google.com, rmoar@google.com,
linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
johannes@sipsolutions.net,
Johannes Berg <johannes.berg@intel.com>,
regressions@lists.linux.dev
Subject: Re: [PATCH v2 1/3] kunit: tool: add subscripts for type annotations where appropriate
Date: Mon, 1 May 2023 11:19:22 -0700 [thread overview]
Message-ID: <CAGS_qxqUUX=V+DfYp8LnjxB03OeZVhaXpmg_8zW98zvJLCcZ6A@mail.gmail.com> (raw)
In-Reply-To: <20230501171520.138753-1-sj@kernel.org>
On Mon, May 1, 2023 at 10:15 AM SeongJae Park <sj@kernel.org> wrote:
>
[snip]
> >
> > It seems like support for the subscript wasn't added until Python 3.9.
> >
> > I know support for subscripting other types like re.Pattern was added
> > in 3.9 per https://peps.python.org/pep-0585/ but it doesn't mention
> > Popen there...
> > This patch also added typing.IO[str] and concurrent.Future[None], so
> > those might be problematic too.
> >
> > Can you check if the typing.IO and concurrent.Future[None] changes
> > cause problems?
> > (I don't have an easy way of testing against older Python versions currently).
>
> Thank you for quick reply. Reverting Popen changes only as below fixed my
> issue. So seems typing.IO and concurrent.Future[None] chages doesn't cause
> problems at least for my use case.
Sounds good.
Sent https://lore.kernel.org/linux-kselftest/20230501181610.2617032-1-dlatypov@google.com
I was hoping adding `--python-version 3.7` to the `mypy --strict`
invocation would help, but it still fails for me :\
$ ./tools/testing/kunit/run_cheks.py
...
mypy: FAILED
> kunit_kernel.py:95: error: Missing type parameters for generic type "Popen" [type-arg]
> kunit_kernel.py:116: error: Missing type parameters for generic type "Popen" [type-arg]
> kunit_kernel.py:145: error: Missing type parameters for generic type "Popen" [type-arg]
> Found 3 errors in 1 file (checked 8 source files)
And here I was, hoping it would complain about code incompatible with
python 3.7...
But at the very least, that patch should fix the current problem.
Daniel
prev parent reply other threads:[~2023-05-01 18:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 22:06 [PATCH v2 1/3] kunit: tool: add subscripts for type annotations where appropriate Daniel Latypov
2023-03-16 22:06 ` [PATCH v2 2/3] kunit: tool: remove unused imports and variables Daniel Latypov
2023-03-17 5:47 ` David Gow
2023-03-16 22:06 ` [PATCH v2 3/3] kunit: tool: fix pre-existing `mypy --strict` errors and update run_checks.py Daniel Latypov
2023-03-17 5:50 ` David Gow
2023-03-17 5:45 ` [PATCH v2 1/3] kunit: tool: add subscripts for type annotations where appropriate David Gow
2023-04-30 18:15 ` SeongJae Park
2023-04-30 21:34 ` Daniel Latypov
2023-05-01 17:15 ` SeongJae Park
2023-05-01 18:19 ` Daniel Latypov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGS_qxqUUX=V+DfYp8LnjxB03OeZVhaXpmg_8zW98zvJLCcZ6A@mail.gmail.com' \
--to=dlatypov@google.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=rmoar@google.com \
--cc=sj@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.