From: Daniel Latypov <dlatypov@google.com>
To: "Maíra Canal" <mairacanal@riseup.net>
Cc: "André Almeida" <andrealmeid@riseup.net>,
melissa.srw@gmail.com, daniel@ffwll.ch, javierm@redhat.com,
siqueirajordao@riseup.net,
"Isabella Basso" <isabbasso@riseup.net>,
jose.exposito89@gmail.com, magalilemes00@gmail.com,
tales.aparecida@gmail.com, davidgow@google.com,
davem@davemloft.net,
"Brendan Higgins" <brendanhiggins@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, airlied@linux.ie, kuba@kernel.org
Subject: Re: [PATCH 2/3] kunit: add KUnit array assertions to the example_all_expect_macros_test
Date: Tue, 2 Aug 2022 12:56:30 -0700 [thread overview]
Message-ID: <CAGS_qxrYGrvg--bmdJ8zOV8+hCcY6=OZj0FtqheNtGP81XFL6Q@mail.gmail.com> (raw)
In-Reply-To: <5931f10d-09ac-84f3-f5d1-65039478ae97@riseup.net>
On Tue, Aug 2, 2022 at 12:00 PM Maíra Canal <mairacanal@riseup.net> wrote:
> > I don't know how we make a maximally fool-proof version of this macro :\
>
> This is a hard one also. I believe that use KUNIT_EXPECT_ARREQ(test,
> expected, expected, sizeof(expected)); is more compliant to the
> memcpy/memset/memcmp signature. Moreover, this problem also occur for
> the KUNIT_EXPECT_EQ(test, memcmp(expected, expected, sizeof(expected)), 0);
>
> I believe that the number of array elements will make it easier for
> users to avoid mistakes.
Actually, another idea: perhaps KUNIT_EXPECT_MEMEQ?
I think that might be clearer in terms of the semantics and people
could more easily infer the right unit (bytes).
Daniel
next prev parent reply other threads:[~2022-08-02 19:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 16:12 [PATCH 0/3] Introduce KUNIT_EXPECT_ARREQ and KUNIT_EXPECT_ARRNEQ macros Maíra Canal
2022-08-02 16:12 ` [PATCH 1/3] kunit: " Maíra Canal
2022-08-02 16:17 ` André Almeida
2022-08-02 18:19 ` Daniel Latypov
2022-08-02 16:12 ` [PATCH 2/3] kunit: add KUnit array assertions to the example_all_expect_macros_test Maíra Canal
2022-08-02 16:19 ` André Almeida
2022-08-02 18:15 ` Daniel Latypov
2022-08-02 19:00 ` Maíra Canal
2022-08-02 19:56 ` Daniel Latypov [this message]
2022-08-02 16:12 ` [PATCH 3/3] kunit: use KUNIT_EXPECT_ARREQ macro Maíra Canal
2022-08-02 16:59 ` [PATCH 0/3] Introduce KUNIT_EXPECT_ARREQ and KUNIT_EXPECT_ARRNEQ macros Daniel Latypov
2022-08-02 18:43 ` Maíra Canal
2022-08-02 19:36 ` Daniel Latypov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGS_qxrYGrvg--bmdJ8zOV8+hCcY6=OZj0FtqheNtGP81XFL6Q@mail.gmail.com' \
--to=dlatypov@google.com \
--cc=airlied@linux.ie \
--cc=andrealmeid@riseup.net \
--cc=brendanhiggins@google.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=isabbasso@riseup.net \
--cc=javierm@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=kuba@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=magalilemes00@gmail.com \
--cc=mairacanal@riseup.net \
--cc=melissa.srw@gmail.com \
--cc=siqueirajordao@riseup.net \
--cc=tales.aparecida@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.