From: Kees Cook <keescook@chromium.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Shuah Khan" <shuah@kernel.org>,
"Martin Fuzzey" <mfuzzey@parkeon.com>,
"Mimi Zohar" <zohar@linux.vnet.ibm.com>,
"David Howells" <dhowells@redhat.com>,
pali.rohar@gmail.com, "Takashi Iwai" <tiwai@suse.de>,
arend.vanspriel@broadcom.com, "Rafał Miłecki" <zajec5@gmail.com>,
nbroeking@me.com, "Vikram Mulukutla" <markivx@codeaurora.org>,
stephen.boyd@linaro.org, "Mark Brown" <broonie@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
Abhay_Salunke@dell.com, bjorn.andersson@linaro.org,
jewalt@lgsinnovations.com, LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 07/11] firmware: split firmware fallback functionality into its own file
Date: Tue, 27 Feb 2018 21:33:28 -0800 [thread overview]
Message-ID: <CAGXu5j+tFg+rGn5baCFRF5ARwExuD45oRE=dmzB8T84XDL=f-w@mail.gmail.com> (raw)
In-Reply-To: <20180228012802.GG14069@wotan.suse.de>
On Tue, Feb 27, 2018 at 5:28 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> On Tue, Feb 27, 2018 at 03:14:53PM -0800, Kees Cook wrote:
>> On Fri, Feb 23, 2018 at 6:46 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
>> > The firmware fallback code is optional. Split that code out to help
>> > distinguish the fallback functionlity from othere core firmware loader
>> > features. This should make it easier to maintain and review code
>> > changes.
>> >
>> > The reason for keeping the configuration onto a table which is built-in
>> > if you enable firmware loading is so that we can later enable the kernel
>> > after subsequent patches to tweak this configuration, even if the
>> > firmware loader is modular.
>> >
>> > This introduces no functional changes.
>> >
>> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
>> > ---
>> > drivers/base/Makefile | 4 +-
>> > drivers/base/firmware_fallback.c | 661 +++++++++++++++++++++++++++
>> > drivers/base/firmware_fallback.h | 61 +++
>> > drivers/base/firmware_fallback_table.c | 29 ++
>> > drivers/base/firmware_loader.c | 803 +--------------------------------
>> > drivers/base/firmware_loader.h | 115 +++++
>> > 6 files changed, 874 insertions(+), 799 deletions(-)
>> > create mode 100644 drivers/base/firmware_fallback.c
>> > create mode 100644 drivers/base/firmware_fallback.h
>> > create mode 100644 drivers/base/firmware_fallback_table.c
>> > create mode 100644 drivers/base/firmware_loader.h
>>
>> Does it make sense to have a separate subdirectory for firmware
>> instead? I did this _ stuff with lkdtm and have regretted it. (I'm
>> likely going to make a subdirectory for it this cycle...)
>
> Sure, the only eyesore is that drivers/base/firmware.c what is that for?
>
> drivers/base/firmware_loader/ ok?
Yeah? Seems fine to me. Greg, do you have thoughts on this?
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2018-02-28 5:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 2:46 [PATCH v2 00/11] firmware: cleanup for v4.17 Luis R. Rodriguez
2018-02-24 2:46 ` [PATCH v2 01/11] test_firmware: enable custom fallback testing on limited kernel configs Luis R. Rodriguez
2018-02-27 23:07 ` Kees Cook
2018-02-24 2:46 ` [PATCH v2 02/11] test_firmware: replace syfs fallback check with kconfig_has helper Luis R. Rodriguez
2018-02-27 23:09 ` Kees Cook
2018-02-24 2:46 ` [PATCH v2 03/11] firmware: enable to split firmware_class into separate target files Luis R. Rodriguez
2018-02-24 2:46 ` [PATCH v2 04/11] firmware: simplify CONFIG_FW_LOADER_USER_HELPER_FALLBACK further Luis R. Rodriguez
2018-02-27 23:20 ` Kees Cook
2018-02-24 2:46 ` [PATCH v2 05/11] firmware: use helpers for setting up a temporary cache timeout Luis R. Rodriguez
2018-02-27 23:20 ` Kees Cook
2018-02-24 2:46 ` [PATCH v2 06/11] firmware: move loading timeout under struct firmware_fallback_config Luis R. Rodriguez
2018-02-27 23:21 ` Kees Cook
2018-02-24 2:46 ` [PATCH v2 07/11] firmware: split firmware fallback functionality into its own file Luis R. Rodriguez
2018-02-27 23:14 ` Kees Cook
2018-02-28 1:28 ` Luis R. Rodriguez
2018-02-28 5:33 ` Kees Cook [this message]
2018-02-28 7:11 ` Greg KH
2018-03-08 3:44 ` Luis R. Rodriguez
2018-02-24 2:46 ` [PATCH v2 08/11] firmware: enable run time change of forcing fallback loader Luis R. Rodriguez
2018-02-27 23:22 ` Kees Cook
2018-02-24 2:46 ` [PATCH v2 09/11] firmware: enable to force disable the fallback mechanism at run time Luis R. Rodriguez
2018-02-27 23:23 ` Kees Cook
2018-02-24 2:46 ` [PATCH v2 10/11] test_firmware: add a library for shared helpers Luis R. Rodriguez
2018-02-27 23:16 ` Kees Cook
2018-02-24 2:46 ` [PATCH v2 11/11] test_firmware: test three firmware kernel configs using a proc knob Luis R. Rodriguez
2018-02-27 23:18 ` Kees Cook
2018-02-28 1:32 ` Luis R. Rodriguez
2018-02-28 9:07 ` Josh Triplett
2018-02-28 18:26 ` Luis R. Rodriguez
2018-03-01 0:00 ` Josh Triplett
2018-03-01 0:38 ` Luis R. Rodriguez
2018-03-01 2:25 ` Josh Triplett
2018-03-01 17:33 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2018-02-14 0:41 [PATCH v2 00/11] firmware: cleanup for v4.17 Luis R. Rodriguez
2018-02-14 0:41 ` [PATCH v2 07/11] firmware: split firmware fallback functionality into its own file Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5j+tFg+rGn5baCFRF5ARwExuD45oRE=dmzB8T84XDL=f-w@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=Abhay_Salunke@dell.com \
--cc=akpm@linux-foundation.org \
--cc=arend.vanspriel@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jewalt@lgsinnovations.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=mcgrof@kernel.org \
--cc=mfuzzey@parkeon.com \
--cc=nbroeking@me.com \
--cc=pali.rohar@gmail.com \
--cc=shuah@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zajec5@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.