From: Richard Fung <richardfung@google.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, fsverity@lists.linux.dev,
ynaffit@google.com
Subject: Re: [PATCH v2] fuse: Add initial support for fs-verity
Date: Mon, 22 Apr 2024 09:31:17 -0700 [thread overview]
Message-ID: <CAGndiTNW=AAy8p6520Q2dDoGJbstN5LAvvbO9ELHHtqGbQZAzQ@mail.gmail.com> (raw)
In-Reply-To: <20240419170511.GB1131@sol.localdomain>
On Fri, Apr 19, 2024 at 10:05 AM Eric Biggers <ebiggers@kernel.org> wrote:
> It's a bit awkward that the ioctl number is checked twice, though. Maybe rename
> the new function to fuse_setup_special_ioctl() and call it unconditionally?
>
> - Eric
I'm happy to change it but the benefit of the current iteration is
that it's much more obvious to someone unfamiliar with the code that
code path is only used for fs-verity. Admittedly, I may be
overindexing on the importance of that as someone who's trying to
learn the codebase myself.
Let me know if you still prefer I change it
next prev parent reply other threads:[~2024-04-22 16:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 20:58 [PATCH 0/1] fuse: Add initial support for fs-verity Richard Fung
2024-03-28 20:58 ` [PATCH 1/1] " Richard Fung
2024-04-02 16:16 ` Richard Fung
2024-04-09 14:50 ` Miklos Szeredi
2024-04-09 23:50 ` Eric Biggers
2024-04-11 6:06 ` Miklos Szeredi
2024-04-11 19:15 ` Richard Fung
2024-04-12 8:25 ` Miklos Szeredi
2024-04-09 23:52 ` [PATCH 0/1] " Eric Biggers
2024-04-16 0:16 ` [PATCH v2] " Richard Fung
2024-04-19 17:05 ` Eric Biggers
2024-04-22 16:31 ` Richard Fung [this message]
2024-04-23 9:31 ` Miklos Szeredi
2024-04-23 18:41 ` Richard Fung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGndiTNW=AAy8p6520Q2dDoGJbstN5LAvvbO9ELHHtqGbQZAzQ@mail.gmail.com' \
--to=richardfung@google.com \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=ynaffit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.