From: Chris Bagwell <chris@cnpbagwell.com>
To: Ping Cheng <pinglinux@gmail.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
rydberg@euromail.se, Ping Cheng <pingc@wacom.com>
Subject: Re: [PATCH 1/3 v2] input : wacom - Add serial number for Graphire4 and old Bamboo
Date: Tue, 5 Jul 2011 21:15:41 -0500 [thread overview]
Message-ID: <CAGzDe_ZoXYkRzLPwzeMd4Vkt4H7tbzS=ga7yerxCH3nU27ouNA@mail.gmail.com> (raw)
In-Reply-To: <1309908304-18792-1-git-send-email-pinglinux@gmail.com>
On Tue, Jul 5, 2011 at 6:25 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> With the removal of BTN_TOOL_FINGER for tablet buttons and
> expresskeys, serial number is needed to distingush if the
> events were from a regular tool (stylus, eraser, or mouse)
> or the attribures (buttons, strips, or wheels) on the tablet
> since there are overlapped events between the tools and the
> tablet attributes.
>
> Signed-off-by: Ping Cheng <pingc@wacom.com>
This patch I believe will even work in isolation of others in series
and will fix some pad button issues reported by various graphire
users.
Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
> ---
> drivers/input/tablet/wacom_wac.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 7ce1294..b93501a 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -265,6 +265,7 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
> wacom->id[0] = 0;
> input_report_abs(input, ABS_MISC, wacom->id[0]); /* report tool id */
> input_report_key(input, wacom->tool[0], prox);
> + input_event(input, EV_MSC, MSC_SERIAL, 1);
> input_sync(input); /* sync last event */
> }
>
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-07-06 2:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 23:25 [PATCH 1/3 v2] input : wacom - Add serial number for Graphire4 and old Bamboo Ping Cheng
2011-07-06 2:15 ` Chris Bagwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGzDe_ZoXYkRzLPwzeMd4Vkt4H7tbzS=ga7yerxCH3nU27ouNA@mail.gmail.com' \
--to=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pingc@wacom.com \
--cc=pinglinux@gmail.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.