Re: [EXTERNAL] Re: [PATCH V7 net] net: mana: Fix MANA VF unload when hardware is

From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
To: Souradeep Chakrabarti <schakrabarti@microsoft.com>
Cc: Simon Horman <horms@kernel.org>,
	 Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>,
	KY Srinivasan <kys@microsoft.com>,
	 Haiyang Zhang <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>,
	 Dexuan Cui <decui@microsoft.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	 "edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	 "pabeni@redhat.com" <pabeni@redhat.com>,
	Long Li <longli@microsoft.com>,
	 Ajay Sharma <sharmaajay@microsoft.com>,
	"leon@kernel.org" <leon@kernel.org>,
	 "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
	 "ssengar@linux.microsoft.com" <ssengar@linux.microsoft.com>,
	vkuznets <vkuznets@redhat.com>,
	 "tglx@linutronix.de" <tglx@linutronix.de>,
	 "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	 "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	 "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH V7 net] net: mana: Fix MANA VF unload when hardware is
Date: Wed, 2 Aug 2023 10:57:52 +0530	[thread overview]
Message-ID: <CAH-L+nPsuoJfCQcJnpMWk5DPGev8f+YWi0K4V+fU=5-bxP5GVw@mail.gmail.com> (raw)
In-Reply-To: <PUZP153MB0788A2C4FC7A76D2CDD021BCCC0AA@PUZP153MB0788.APCP153.PROD.OUTLOOK.COM>

[-- Attachment #1.1: Type: text/plain, Size: 2112 bytes --]

Hi Souradeep,

It looks like the subject line is not complete. I could see "net: mana: Fix
MANA VF unload when hardware is".

Is that correct?

Regards,
Kalesh

On Wed, Aug 2, 2023 at 12:29 AM Souradeep Chakrabarti <
schakrabarti@microsoft.com> wrote:

>
>
> >-----Original Message-----
> >From: Simon Horman <horms@kernel.org>
> >Sent: Tuesday, August 1, 2023 9:01 PM
> >To: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> >Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> ><haiyangz@microsoft.com>; wei.liu@kernel.org; Dexuan Cui
> ><decui@microsoft.com>; davem@davemloft.net; edumazet@google.com;
> >kuba@kernel.org; pabeni@redhat.com; Long Li <longli@microsoft.com>; Ajay
> >Sharma <sharmaajay@microsoft.com>; leon@kernel.org;
> >cai.huoqing@linux.dev; ssengar@linux.microsoft.com; vkuznets
> ><vkuznets@redhat.com>; tglx@linutronix.de; linux-hyperv@vger.kernel.org;
> >netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> >rdma@vger.kernel.org; Souradeep Chakrabarti
> ><schakrabarti@microsoft.com>; stable@vger.kernel.org
> >Subject: [EXTERNAL] Re: [PATCH V7 net] net: mana: Fix MANA VF unload when
> >hardware is
> >
> >On Tue, Aug 01, 2023 at 05:29:13AM -0700, Souradeep Chakrabarti wrote:
> >
> >...
> >
> >Hi Souradeep,
> >
> >
> >> +    for (i = 0; i < apc->num_queues; i++) {
> >> +            txq = &apc->tx_qp[i].txq;
> >> +            while (skb = skb_dequeue(&txq->pending_skbs)) {
> >
> >W=1 builds with both clang-16 and gcc-12 complain that they would like an
> >extra set of parentheses around an assignment used as a truth value.
> Thanks for letting me know. I will fix it in next version.
> >
> >> +                    mana_unmap_skb(skb, apc);
> >> +                    dev_consume_skb_any(skb);
> >> +            }
> >> +            atomic_set(&txq->pending_sends, 0);
> >> +    }
> >>      /* We're 100% sure the queues can no longer be woken up, because
> >>       * we're sure now mana_poll_tx_cq() can't be running.
> >>       */
> >> --
> >> 2.34.1
> >>
> >>
>
>

-- 
Regards,
Kalesh A P

[-- Attachment #1.2: Type: text/html, Size: 5101 bytes --]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]