Re: [RFC PATCH v2 05/10] cifs: convert server info vars to snake_case

From: Steve French <smfrench@gmail.com>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: linux-cifs@vger.kernel.org, pc@cjr.nz, ronniesahlberg@gmail.com,
	nspmangalore@gmail.com
Subject: Re: [RFC PATCH v2 05/10] cifs: convert server info vars to snake_case
Date: Wed, 27 Jul 2022 10:29:10 -0500	[thread overview]
Message-ID: <CAH2r5msf=Tm9MEmxqvOsWxv=VJP_uKQAtKhnphymhKiBOi6azQ@mail.gmail.com> (raw)
In-Reply-To: <20220727151706.wxqowyibon5h3huz@cyberdelia>

On Wed, Jul 27, 2022 at 10:17 AM Enzo Matsumiya <ematsumiya@suse.de> wrote:
>
> On 07/27, Steve French wrote:
> >I doubt that renaming tcpStatus to "status" helps much.  If it has to
> >do with the socket, included tcp or socket or connection in the name
> >seems plausible/helpful.  I don't mind removing the came cause (e.g.
> >"tcp_status" or something similar) but prefer other types of cleanup
> >to be the focus (moving smb1 code out of mixed smb1/smb2/smb3 c files
> >into smb1 specific ones that are compiled out when legacy is disabled
> >etc.
>
> Steve, the way I see it is, if we have a struct names "server_info" or
> similar, there's no need to include a prefix in its fields' names,
> especially when there's only one "status" variable for that struct
> (which should always be the case), e.g. "server->server_status" looks
> ugly and one might assume that "server" holds another different status,

That point makes sense - but these kind of renames are lower priority
than getting the features/bugfixes cleaned up for the merge window.

Lots of interesting things to work on relating to multichannel,
leases, compression support, signing negotation (helps perf),
fixing the swapfile feature, sparse file improvements,
more testing of posix extensions etc.