From: Steve French <smfrench@gmail.com>
To: Paulo Alcantara <pc@cjr.nz>
Cc: Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH 5/9] cifs: Do not access tcon->cfids->cfid directly from is_path_accessible
Date: Thu, 11 Aug 2022 19:56:30 -0500 [thread overview]
Message-ID: <CAH2r5mvCuJM5z5nzfXW6Mkqgo4CWxoORUhsNT4ZtrjS=tVSJxg@mail.gmail.com> (raw)
In-Reply-To: <87leruudal.fsf@cjr.nz>
Tentatively merged this patch (after rebasing it and fixing a minor
checkpatch problem). Added Paulo's RB
Skipped adding patch 4 though (cifs: Make tcon contain a wrapper
structure cached_fids instead of cached_fid) - let me know if problem
skipping that patch in the short term
On Thu, Aug 11, 2022 at 8:20 AM Paulo Alcantara <pc@cjr.nz> wrote:
>
> Ronnie Sahlberg <lsahlber@redhat.com> writes:
>
> > cfids will soon keep a list of cached fids so we should not access this
> > directly from outside of cached_dir.c
> >
> > Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> > ---
> > fs/cifs/cached_dir.c | 10 ++++++----
> > fs/cifs/cached_dir.h | 2 +-
> > fs/cifs/readdir.c | 4 ++--
> > fs/cifs/smb2inode.c | 2 +-
> > fs/cifs/smb2ops.c | 18 ++++++++++++++----
> > 5 files changed, 24 insertions(+), 12 deletions(-)
>
> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
--
Thanks,
Steve
next prev parent reply other threads:[~2022-08-12 0:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 2:11 WIP: Expand directory handle cache to also cache non-root directories Ronnie Sahlberg
2022-08-09 2:11 ` [PATCH 1/9] cifs: Move cached-dir functions into a separate file Ronnie Sahlberg
2022-08-11 2:53 ` Steve French
2022-08-11 3:08 ` Steve French
2022-08-11 13:03 ` Paulo Alcantara
2022-08-09 2:11 ` [PATCH 2/9] cifs: Do not use tcon->cfid directly, use the cfid we get from open_cached_dir Ronnie Sahlberg
2022-08-09 4:22 ` Steve French
2022-08-11 13:03 ` Paulo Alcantara
2022-08-09 2:11 ` [PATCH 3/9] cifs: Add constructor/destructors for tcon->cfid Ronnie Sahlberg
2022-08-11 13:15 ` Paulo Alcantara
2022-08-12 0:14 ` Steve French
2022-08-09 2:11 ` [PATCH 4/9] cifs: Make tcon contain a wrapper structure cached_fids instead of cached_fid Ronnie Sahlberg
2022-08-11 13:16 ` Paulo Alcantara
2022-08-09 2:11 ` [PATCH 5/9] cifs: Do not access tcon->cfids->cfid directly from is_path_accessible Ronnie Sahlberg
2022-08-11 13:20 ` Paulo Alcantara
2022-08-12 0:56 ` Steve French [this message]
2022-08-12 0:57 ` Steve French
2022-08-12 1:26 ` Steve French
2022-08-12 1:34 ` Steve French
2022-08-09 2:11 ` [PATCH 6/9] cifs: cifs: handlecache, only track the dentry for the root handle Ronnie Sahlberg
2022-08-11 13:34 ` Paulo Alcantara
2022-08-09 2:11 ` [PATCH 7/9] cifs: store a pointer to a fid in the cfid structure instead of the struct Ronnie Sahlberg
2022-08-11 13:37 ` Paulo Alcantara
2022-08-09 2:11 ` [PATCH 8/9] cifs: don't unlock cifs_tcp_ses_lock in cached_dir_lease_break() Ronnie Sahlberg
2022-08-11 13:38 ` Paulo Alcantara
2022-08-11 15:27 ` Steve French
2022-08-09 2:11 ` [PATCH 9/9] cifs: start caching all directories we open and get a lease for Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mvCuJM5z5nzfXW6Mkqgo4CWxoORUhsNT4ZtrjS=tVSJxg@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=pc@cjr.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.