Re: [PATCH 00/22] Move LSM hook comments into security/security.c

From: Paul Moore <paul@paul-moore.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH 00/22] Move LSM hook comments into security/security.c
Date: Mon, 6 Mar 2023 13:49:11 -0500	[thread overview]
Message-ID: <CAHC9VhQnjmX9n2KJhj97SnQfuO50kaJxX3p8p4gHBC5mBkLfxg@mail.gmail.com> (raw)
In-Reply-To: <20230217032625.678457-1-paul@paul-moore.com>

On Thu, Feb 16, 2023 at 10:26 PM Paul Moore <paul@paul-moore.com> wrote:
>
> Hello all,
>
> The LSM hook comment blocks are a in a rather sad state; separated from
> the hook definitions they are often out of mind, and as a result
> most of them are in varying levels of bit-rot, some severely.  This
> patchset moves all of the comment blocks out of lsm_hooks.c and onto
> the top of the function definitions as one would normally expect.
> In the process of moving the comment blocks, they have been massaged
> into the standard kernel-doc format for the sake of consistency and
> easier reading.  Unfortunately, correcting all of the errors in the
> comments would have made an extremely long and painful task even worse,
> so a number of errors remain, but the worst offenders were corrected in
> the move.  Now that the comments are in the proper location, and in the
> proper format, my hope is that future patch submissions correcting the
> actual comment contents will be much easier and the comments as a whole
> will be easier to maintain.
>
> There are no code changes in this patchset, although since I was
> already adding a lot of churn to security.c, the last patch in this
> patchset (22/22) does take the liberty of fixing some rather ugly
> style problems.
>
>  include/linux/lsm_hooks.h | 1624 +++++++++++++++++++++
>  security/security.c       | 2702 +---------------------------------------
>  2 files changed, 1710 insertions(+), 2616 deletions(-)

Seeing no objections, and the ACK from Casey, I've gone ahead and
merged this patchset into the lsm/next branch.  There was some minor
merge fuzz due to the mount idmap work and some IMA changes, but the
vast majority of the patchset is exactly as posted.

-- 
paul-moore.com