From: Paul Moore <paul@paul-moore.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: selinux@tycho.nsa.gov, guido@trentalancia.net,
richard_c_haines@btinternet.com
Subject: Re: [PATCH v2] selinux: support distinctions among all network address families
Date: Fri, 9 Dec 2016 18:56:48 -0500 [thread overview]
Message-ID: <CAHC9VhQoCxy5t6xg5o3A_a=vK1p=gar588SzGB5k5naV+xVeRg@mail.gmail.com> (raw)
In-Reply-To: <71adc3b1-e882-532c-de2a-7b9b7974d2ca@tycho.nsa.gov>
On Thu, Dec 8, 2016 at 2:42 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> Wanted to clarify one point and also mention a bug/deficiency of this
> patch that I just realized:
>
> - Clarification: At present, the patch will map PF_INET, SOCK_DGRAM,
> IPPROTO_ICMP to icmp_socket, but will continue to map PF_INET, SOCK_RAW,
> IPPROTO_ICMP to rawip_socket. That's intentional, since the SOCK_DGRAM
> IPPROTO_ICMP sockets were introduced to provide a more restricted form
> of ICMP sockets that could be exposed to unprivileged users (based on a
> sysctl), so distinguishing those in policy makes sense. But it could be
> surprising.
Yes, I have no problem with this behavior.
> - Bug/deficiency: I hadn't noticed that there is a separate
> IPPROTO_ICMPV6, so I'll need to modify this patch or post a follow-on
> that ensure that we map SOCK_DGRAM,IPPROTO_ICMPV6 to icmp_socket too.
Merged your follow-up patch.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2016-12-09 23:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 15:00 [PATCH v2] selinux: support distinctions among all network address families Stephen Smalley
2016-12-07 0:13 ` Paul Moore
2016-12-07 13:25 ` Stephen Smalley
2016-12-07 15:14 ` Paul Moore
2016-12-07 15:24 ` Stephen Smalley
2016-12-07 23:32 ` Paul Moore
2016-12-08 16:24 ` Stephen Smalley
2016-12-08 19:42 ` Stephen Smalley
2016-12-09 23:56 ` Paul Moore [this message]
2016-12-07 15:15 ` Guido Trentalancia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhQoCxy5t6xg5o3A_a=vK1p=gar588SzGB5k5naV+xVeRg@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=guido@trentalancia.net \
--cc=richard_c_haines@btinternet.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.