From: Paul Moore <paul@paul-moore.com>
To: Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: Ondrej Mosnacek <omosnace@redhat.com>,
SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] selinux: remove the 'initialized' flag from selinux_state
Date: Thu, 27 Aug 2020 10:05:32 -0400 [thread overview]
Message-ID: <CAHC9VhRf7Sb1H8sGrjo6JySegVDQB0_YviLt3NWY84Zw8fec5A@mail.gmail.com> (raw)
In-Reply-To: <CAEjxPJ5HRQQprNoqe0O7M73Tk3m+kRAqutHY5Ucb-8eH-YUEsQ@mail.gmail.com>
On Wed, Aug 26, 2020 at 10:15 AM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Wed, Aug 26, 2020 at 9:59 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > After the RCU conversion, it is possible to simply check the policy
> > pointer against NULL instead.
> >
> > Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
>
> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Looks fine to me as well, but it doesn't merge cleanly and since you
are already respinning patch 1/3 I figured I would just bail on this
patch and let you take care ot it.
I would suggest dropping patch 2/3 from the patchset, respinning
patches 1/3 and 3/3, and reposting them for inclusion into
selinux/next. That's likely the quickest way forward on these.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-08-27 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 13:59 [PATCH v2 0/3] selinux: RCU conversion follow-ups Ondrej Mosnacek
2020-08-26 13:59 ` [PATCH v2 1/3] selinux: simplify away security_policydb_len() Ondrej Mosnacek
2020-08-26 14:05 ` Stephen Smalley
2020-08-27 13:56 ` Paul Moore
2020-08-27 13:57 ` Paul Moore
2020-08-26 13:59 ` [PATCH v2 2/3] selinux: eliminate the redundant policycap array Ondrej Mosnacek
2020-08-26 14:11 ` Stephen Smalley
2020-08-27 7:40 ` Ondrej Mosnacek
2020-08-26 13:59 ` [PATCH v2 3/3] selinux: remove the 'initialized' flag from selinux_state Ondrej Mosnacek
2020-08-26 14:15 ` Stephen Smalley
2020-08-27 14:05 ` Paul Moore [this message]
2020-08-27 14:16 ` Stephen Smalley
2020-08-27 14:23 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhRf7Sb1H8sGrjo6JySegVDQB0_YviLt3NWY84Zw8fec5A@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.