All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: casey.schaufler@intel.com, linux-audit@redhat.com
Subject: Re: [PATCH v15 21/23] Audit: Include object data for all security modules
Date: Mon, 9 Mar 2020 13:59:48 -0400	[thread overview]
Message-ID: <CAHC9VhRiqHAJLBNLxLrFHsevSdV0bG_P_YFWV6Kw00ZGTKduHw@mail.gmail.com> (raw)
In-Reply-To: <42b3a4f0-c6ee-516a-7d10-726222c42b78@schaufler-ca.com>

On Mon, Mar 9, 2020 at 1:45 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
> On 3/6/2020 6:31 PM, Paul Moore wrote:
> > Either way, the "obj=" field should stay where it is, but the
> > "obj_XXX=" fields need to find their way to the end of the record.
>
> As Steve pointed out, there may be a bigger issue here. If the additional
> fields aren't going to fit in MAX_AUDIT_MESSAGE_LENGTH bytes another
> format may be required. I had hoped that perhaps obj_selinux= might count
> as a refinement to obj= and hence not be considered a new field, but
> it looks like that's not flying.

Regardless, the field placement guidance remains the same.

As far as the record limitation; yes, Steve's audit userspace does
have a limit, but I do wonder how limiting an 8k record size really is
for the majority of systems.  My guess is "not too bad".  If you are
concerned about that, I imagine you could always tack on a new record
to relevant events with additional LSM subj/obj info.  Some of the
audit container ID pre-work have made that less painful than it would
have been in the past, but it will still be a bit of work to get it
right.

-- 
paul moore
www.paul-moore.com


--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit


  reply	other threads:[~2020-03-09 18:00 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200222000407.110158-1-casey.ref@schaufler-ca.com>
2020-02-22  0:03 ` [PATCH v15 00/23] LSM: Module stacking for AppArmor Casey Schaufler
2020-02-22  0:03   ` Casey Schaufler
2020-02-22  0:03   ` [PATCH v15 01/23] LSM: Infrastructure management of the sock security Casey Schaufler
2020-02-22  0:03     ` Casey Schaufler
2020-02-22  0:03   ` [PATCH v15 02/23] LSM: Create and manage the lsmblob data structure Casey Schaufler
2020-02-22  0:03     ` Casey Schaufler
2020-03-06 20:55     ` Paul Moore
2020-02-22  0:03   ` [PATCH v15 03/23] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2020-02-22  0:03     ` Casey Schaufler
2020-03-06 22:01     ` Paul Moore
2020-03-09 23:58       ` Casey Schaufler
2020-03-10  0:55         ` Paul Moore
2020-02-22  0:03   ` [PATCH v15 07/23] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2020-02-22  0:03     ` Casey Schaufler
2020-03-07  1:17     ` Paul Moore
2020-02-22  0:03   ` [PATCH v15 08/23] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2020-02-22  0:03     ` Casey Schaufler
2020-03-07  1:21     ` Paul Moore
2020-02-22  0:04   ` [PATCH v15 09/23] LSM: Use lsmblob in security_task_getsecid Casey Schaufler
2020-02-22  0:04     ` Casey Schaufler
2020-02-22  0:04   ` [PATCH v15 10/23] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2020-02-22  0:04     ` Casey Schaufler
2020-02-22  0:04   ` [PATCH v15 11/23] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2020-02-22  0:04     ` Casey Schaufler
2020-03-07  1:36     ` Paul Moore
2020-02-22  0:04   ` [PATCH v15 12/23] IMA: Change internal interfaces to use lsmblobs Casey Schaufler
2020-02-22  0:04     ` Casey Schaufler
2020-02-22  0:04   ` [PATCH v15 14/23] LSM: Ensure the correct LSM context releaser Casey Schaufler
2020-02-22  0:04     ` Casey Schaufler
2020-02-22  0:04   ` [PATCH v15 15/23] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2020-02-22  0:04     ` Casey Schaufler
2020-03-07  2:01     ` Paul Moore
2020-02-22  0:04   ` [PATCH v15 20/23] Audit: Add subj_LSM fields when necessary Casey Schaufler
2020-02-22  0:04     ` Casey Schaufler
2020-03-07  2:18     ` Paul Moore
2020-03-07  2:24     ` Paul Moore
2020-03-10  1:25       ` Casey Schaufler
2020-03-10 21:46         ` Paul Moore
2020-02-22  0:04   ` [PATCH v15 21/23] Audit: Include object data for all security modules Casey Schaufler
2020-02-22  0:04     ` Casey Schaufler
2020-03-07  2:31     ` Paul Moore
2020-03-09 17:45       ` Casey Schaufler
2020-03-09 17:59         ` Paul Moore [this message]
2020-03-09 23:01           ` Casey Schaufler
2020-03-10 21:42             ` Paul Moore
2020-02-27 17:29   ` [PATCH v15 00/23] LSM: Module stacking for AppArmor Casey Schaufler
2020-03-03 17:22     ` Casey Schaufler
2020-03-03 17:54       ` Paul Moore
2020-03-03 17:58         ` Casey Schaufler
2020-03-06 17:14       ` Steve Grubb
2020-03-09 17:15         ` Casey Schaufler
2020-02-14 23:41 Casey Schaufler
2020-02-14 23:42 ` [PATCH v15 21/23] Audit: Include object data for all security modules Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHC9VhRiqHAJLBNLxLrFHsevSdV0bG_P_YFWV6Kw00ZGTKduHw@mail.gmail.com \
    --to=paul@paul-moore.com \
    --cc=casey.schaufler@intel.com \
    --cc=casey@schaufler-ca.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.