From: Amit Kucheria <amit.kucheria@verdurent.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/9] thermal: Move default governor config option to the internal header
Date: Sat, 4 Apr 2020 13:00:00 +0530 [thread overview]
Message-ID: <CAHLCerOXZBA9aoH0Ef9tzcsSnKAQUKwuaCNOyJTakf6uCG+11A@mail.gmail.com> (raw)
In-Reply-To: <20200402142747.8307-1-daniel.lezcano@linaro.org>
On Thu, Apr 2, 2020 at 7:58 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> The default governor set at compilation time is a thermal internal
> business, no need to export to the global thermal header.
>
> Move the config options to the internal header.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/thermal/thermal_core.h | 11 +++++++++++
> include/linux/thermal.h | 11 -----------
> 2 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
> index 37cd4e2bead2..828305508556 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -12,6 +12,17 @@
> #include <linux/device.h>
> #include <linux/thermal.h>
>
> +/* Default Thermal Governor */
> +#if defined(CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE)
> +#define DEFAULT_THERMAL_GOVERNOR "step_wise"
> +#elif defined(CONFIG_THERMAL_DEFAULT_GOV_FAIR_SHARE)
> +#define DEFAULT_THERMAL_GOVERNOR "fair_share"
> +#elif defined(CONFIG_THERMAL_DEFAULT_GOV_USER_SPACE)
> +#define DEFAULT_THERMAL_GOVERNOR "user_space"
> +#elif defined(CONFIG_THERMAL_DEFAULT_GOV_POWER_ALLOCATOR)
> +#define DEFAULT_THERMAL_GOVERNOR "power_allocator"
> +#endif
> +
> /* Initial state of a cooling device during binding */
> #define THERMAL_NO_TARGET -1UL
>
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 448841ab0dca..71cff87dcb46 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -32,17 +32,6 @@
> /* use value, which < 0K, to indicate an invalid/uninitialized temperature */
> #define THERMAL_TEMP_INVALID -274000
>
> -/* Default Thermal Governor */
> -#if defined(CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE)
> -#define DEFAULT_THERMAL_GOVERNOR "step_wise"
> -#elif defined(CONFIG_THERMAL_DEFAULT_GOV_FAIR_SHARE)
> -#define DEFAULT_THERMAL_GOVERNOR "fair_share"
> -#elif defined(CONFIG_THERMAL_DEFAULT_GOV_USER_SPACE)
> -#define DEFAULT_THERMAL_GOVERNOR "user_space"
> -#elif defined(CONFIG_THERMAL_DEFAULT_GOV_POWER_ALLOCATOR)
> -#define DEFAULT_THERMAL_GOVERNOR "power_allocator"
> -#endif
> -
> struct thermal_zone_device;
> struct thermal_cooling_device;
> struct thermal_instance;
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-04-04 7:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 14:27 [PATCH V2 1/9] thermal: Move default governor config option to the internal header Daniel Lezcano
2020-04-02 14:27 ` [PATCH V2 2/9] thermal: Move struct thermal_attr to the private header Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 3/9] thermal: Move internal IPA functions Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 4/9] thermal: Move trip point structure definition to private header Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 5/9] thermal: Move get_tz_trend to the internal header Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 6/9] thermal: Move get_thermal_instance " Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 7/9] thermal: Change IS_ENABLED to IFDEF in the header file Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 8/9] thermal: Remove stubs for thermal_zone_[un]bind_cooling_device Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 9/9] thermal: Remove thermal_zone_device_update() stub Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-04 7:30 ` Amit Kucheria [this message]
2020-04-12 8:35 ` [PATCH V2 1/9] thermal: Move default governor config option to the internal header Zhang Rui
2020-04-12 8:39 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerOXZBA9aoH0Ef9tzcsSnKAQUKwuaCNOyJTakf6uCG+11A@mail.gmail.com \
--to=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.