From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Olga Kornievskaia <aglo@umich.edu>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] NFS: Optimise away the close-to-open getattr if there is no cached data
Date: Fri, 4 Sep 2015 16:39:44 -0400 [thread overview]
Message-ID: <CAHQdGtQJEvrwQP_J1xEnzg96YmHbK2LKHDrkYOsaE+pna4Z78w@mail.gmail.com> (raw)
In-Reply-To: <DA83C389-2E91-4A35-ACF5-F14F33D50944@oracle.com>
On Fri, Sep 4, 2015 at 3:38 PM, Chuck Lever <chuck.lever@oracle.com> wrote:
>
> On Sep 4, 2015, at 3:24 PM, Trond Myklebust <trond.myklebust@primarydata.com> wrote:
>
>> If there is no cached data, then there is no need to track the file
>> change attribute on close.
>
> This makes sense. nfs_close_context() is only used by NFSv2
> and NFSv3.
>
> Should you update the documenting comment?
Good point. I'll do that...
prev parent reply other threads:[~2015-09-04 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 19:24 [PATCH 1/2] NFS: Optimise away the close-to-open getattr if there is no cached data Trond Myklebust
2015-09-04 19:24 ` [PATCH 2/2] Revert "NFS: Make close(2) asynchronous when closing NFS O_DIRECT files" Trond Myklebust
2015-09-04 19:38 ` [PATCH 1/2] NFS: Optimise away the close-to-open getattr if there is no cached data Chuck Lever
2015-09-04 20:39 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQdGtQJEvrwQP_J1xEnzg96YmHbK2LKHDrkYOsaE+pna4Z78w@mail.gmail.com \
--to=trond.myklebust@primarydata.com \
--cc=aglo@umich.edu \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.