Re: [PATCH v3 0/7] Standardize onboard LED support for 96Boards

From: Michal Simek <monstr@monstr.eu>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, xuwei5@hisilicon.com,
	LKML <linux-kernel@vger.kernel.org>,
	linux-rockchip@lists.infradead.org, nicolas.dechesne@linaro.org,
	koen.kooi@linaro.org,
	linux-arm <linux-arm-kernel@lists.infradead.org>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Andy Gross" <andy.gross@linaro.org>,
	"Amit Kucheria" <amit.kucheria@linaro.org>,
	ezequiel@collabora.com, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 0/7] Standardize onboard LED support for 96Boards
Date: Wed, 31 Oct 2018 16:46:48 +0100	[thread overview]
Message-ID: <CAHTX3dJTXtuA0i-ffPjoiWuxEcF_5JY55VJtWd9zxW4HxK1K3w@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdYThcGjdV9Ezs4qMr8K6_jH40SDUgt0Tps8d+_4sSESyg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]

Hi,

st 31. 10. 2018 v 14:39 odesílatel Linus Walleij <linus.walleij@linaro.org>
napsal:

> On Mon, Oct 29, 2018 at 10:43 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
>
> > This patchset standardizes the onboard LEDs on 96Boards by maintaining
> > common labels and triggers as below:
> >
> > green:user1  default-trigger: heartbeat
> > green:user2  default-trigger: mmc0/disk-activity (onboard-storage)
> > green:user3  default-trigger: mmc1 (SD card)
> > green:user4  default-trigger: none, panic-indicator
> > yellow:wlan  default-trigger: phy0tx
> > blue:bt      default-trigger: hci0-power
> >
> > This standardization is required to provide a common behaviour of LEDs
> > across all mainline supported 96Boards and also making it easier to
> > control it using an userspace library like MRAA.
> >
> > For Rock960 and Ficus boards, the LED support is added in this patchset.
> > Rest of the boards are converted to adopt the standard.
> >
> > Note: Since there is no UFS trigger available for now, user2 LED trigger
> > is set to none on HiKey960.
>
> This series:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> It makes a lot of sense to try to unify the userspace ABI so we get
> some kind of order here instead of trying to counteract it with
> per-device kludges in userspace. It definately makes things better!
>

No doubt about it that this is good. If this is there from day 1 all will
be good.
I am just saying that we are all the time
saying that we shouldn't break userspace. Right now if there is single
application
which uses existing names we are breaking it.

Thanks,
Michal

---
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

[-- Attachment #2: Type: text/html, Size: 2842 bytes --]