From: Linus Torvalds <torvalds@linux-foundation.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [GIT PULL] More Kbuild updates for v5.19-rc1
Date: Sat, 4 Jun 2022 13:25:31 -0700 [thread overview]
Message-ID: <CAHk-=wg-mH-_GYpkhz_psjBWG6ZcjKnPo83fg7YMj_by+-LRTQ@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNATHyNjCaK+agk=DOTR8sPaOP9kBvS_xYaBUHfF+5Fzftg@mail.gmail.com>
On Fri, Jun 3, 2022 at 9:42 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> - Fix modpost to detect EXPORT_SYMBOL marked as __init or__exit
> (This uncovered a couple of potential issues of exported symbols)
I pulled, and then unpulled again, since this introduces new warnings.
If you introduce new checks, you fix what it checks.
And if the warnings didn't get sorted out, then it wasn't ready to be merged.
There's a good *reason* I require a clean build: non-clean builds
just mean that people will ignore new warnings because they think they
are the old ones that they have already seen.
So no, it is *NOT* ok to introduce new warnings and think "people will
fix these up because now there are warnings about it".
Quite the reverse. People not only *won't* fix things up, and it will
just hide new warnings from *other* things instead.
Linus
next prev parent reply other threads:[~2022-06-04 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 16:41 [GIT PULL] More Kbuild updates for v5.19-rc1 Masahiro Yamada
2022-06-04 20:25 ` Linus Torvalds [this message]
2022-06-04 21:33 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wg-mH-_GYpkhz_psjBWG6ZcjKnPo83fg7YMj_by+-LRTQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.