From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mike Marshall <hubcap@omnibond.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [GIT PULL] orangefs: an adjustment and a fix...
Date: Sat, 26 Jun 2021 10:02:02 -0700 [thread overview]
Message-ID: <CAHk-=wgL3d6iZz5s=pCQAx+tz8BMPFUNp8dMmBtGqYCUKg50uQ@mail.gmail.com> (raw)
In-Reply-To: <CAOg9mSR9CM-DV1eqL58HM+m_6fbwgU7KFs3Sab0=A7BOvqoPYQ@mail.gmail.com>
On Sat, Jun 26, 2021 at 7:14 AM Mike Marshall <hubcap@omnibond.com> wrote:
>
> If it is not too late for these... the readahead adjustment
> was suggested by Matthew Wilcox and looks like how I should
> have written it in the first place...
It wasn't too late - I pulled these.
And then I un-pulled them. You removed all the uses of "file", but
left the variable, so it all warns about
fs/orangefs/inode.c: In function ‘orangefs_readahead’:
fs/orangefs/inode.c:252:22: warning: unused variable ‘file’
[-Wunused-variable]
252 | struct file *file = rac->file;
| ^~~~
so clearly this has gotten absolutely zero testing.
Linus
next prev parent reply other threads:[~2021-06-26 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 14:14 [GIT PULL] orangefs: an adjustment and a fix Mike Marshall
2021-06-26 17:02 ` Linus Torvalds [this message]
2021-06-27 14:50 ` Mike Marshall
2021-07-06 13:36 Mike Marshall
2021-07-06 19:24 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgL3d6iZz5s=pCQAx+tz8BMPFUNp8dMmBtGqYCUKg50uQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.