From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs <linux-xfs@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>,
fdmanana@kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Jan Kara <jack@suse.cz>, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [GIT PULL] vfs: fs freeze fix for 5.10-rc4
Date: Fri, 13 Nov 2020 16:13:37 -0800 [thread overview]
Message-ID: <CAHk-=whvWbFBr-W8FvAT1_ekuzWk=q_g+6+_h2ChycsW8dMhmw@mail.gmail.com> (raw)
In-Reply-To: <20201113233847.GG9685@magnolia>
On Fri, Nov 13, 2020 at 3:38 PM Darrick J. Wong <djwong@kernel.org> wrote:
>
> Since the hack is unnecessary and causes thread race errors, just get
> rid of it completely. Pushing this kind of vfs change midway through a
> cycle makes me nervous, but a large enough number of the usual
> VFS/ext4/XFS/btrfs suspects have said this looks good and solves a real
> problem vector, so I'm sending this for your consideration instead of
> holding off until 5.11.
Not a fan of the timing, but you make a good argument, and I love
seeing code removal. So I took it.
And once I took the real code change, the two cleanups looked like the
least of the problem, so I took them too.
I ended up doing it all just as a single pull, since it seemed
pointless to make history more complicated just to separate out the
cleanups in a separate pull.
Now I really hope this won't cause any problems, but it certainly
_looks_ harmless.
Linus
next prev parent reply other threads:[~2020-11-14 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 23:38 [GIT PULL] vfs: fs freeze fix for 5.10-rc4 Darrick J. Wong
2020-11-14 0:13 ` Linus Torvalds [this message]
2020-11-14 0:49 ` Darrick J. Wong
2020-11-14 0:15 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whvWbFBr-W8FvAT1_ekuzWk=q_g+6+_h2ChycsW8dMhmw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fdmanana@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.