From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Deepa Dinamani <deepa.kernel@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] Re: filesystem being remounted supports timestamps until 2038
Date: Sun, 29 Dec 2019 10:01:04 -0800 [thread overview]
Message-ID: <CAHk-=wim6VGnxQmjfK_tDg6fbHYKL4EFkmnTjVr9QnRqjDBAeA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.99999.375.1912261445200.21037@trent.utfs.org>
On Thu, Dec 26, 2019 at 5:54 PM Christian Kujau <lists@nerdbynature.de> wrote:
>
> When file systems are remounted a couple of times per day (e.g. rw/ro for backup
> purposes), dmesg gets flooded with these messages. Change pr_warn into pr_debug
> to make it stop.
How about just doing it once per mount?
IOW, if your issue is that you re-mount things read-only for backups
and then remount it rw again soon afterwards, but it's not actually
_unmounted_, maybe you could instead just add a flag to the 'struct
super_block' saying "this mount has been warned about already"?
That would seem to make sense regardless. No? Partoicularly since we
also don't want to warn multiple times just because the same thing
gets mounted in multiple places.
Of course, if you actually unmount and completely re-mount a
filesystem, then that would still warn multiple times, but at that
point I think it's reasonable to do.
Linus
next prev parent reply other threads:[~2019-12-29 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 2:02 filesystem being remounted supports timestamps until 2038 Christian Kujau
2019-12-27 1:54 ` [PATCH] " Christian Kujau
2019-12-28 19:51 ` Deepa Dinamani
2019-12-29 18:01 ` Linus Torvalds [this message]
2020-01-04 23:51 ` Christian Kujau
2020-06-24 0:26 ` Christian Kujau
2022-01-27 21:49 ` Salvatore Bonaccorso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wim6VGnxQmjfK_tDg6fbHYKL4EFkmnTjVr9QnRqjDBAeA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=deepa.kernel@gmail.com \
--cc=ebiggers@google.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.