From: Linus Torvalds <torvalds@linux-foundation.org>
To: Yuxuan Shui <yshuiv7@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
open list <linux-kernel@vger.kernel.org>,
"Robert O'Callahan" <rocallahan@gmail.com>,
Kyle Huey <me@kylehuey.com>
Subject: Re: [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken
Date: Sun, 31 Jan 2021 12:10:48 -0800 [thread overview]
Message-ID: <CAHk-=wixO7LJKwtD+CQJTQHgJFQjr=sSi_pQEGqcYdczTphncg@mail.gmail.com> (raw)
In-Reply-To: <87v9bdc4yc.fsf@m5Zedd9JOGzJrf0>
On Sun, Jan 31, 2021 at 10:54 AM Yuxuan Shui <yshuiv7@gmail.com> wrote:
>
> But renaming the definition in x86 is not enough, as TIF_SINGLESTEP is
> set in current_thread_info()->flags, and the same commit has removed the
> code that checks those flags. We have to also migrate TIF_SINGLESTEP from
> thread info flags to syscall work flags, to make the whole thing work again.
Ok, so I now have the first fix merged, but what's the next step here?
As you say, the x86 ARCH_SYSCALL_EXIT_WORK is now entirely unused.
It's called ARCH_SYSCALL_WORK_EXIT these days, but that's for the
SYSCALL_WORK_SYSCALL_xyz flags, not for the TIF_xyz ones.
Revert? Or does somebody have a fix patch?
Linus
next prev parent reply other threads:[~2021-01-31 20:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 1:32 [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken Kyle Huey
2021-01-31 1:55 ` Linus Torvalds
2021-01-31 2:50 ` Kyle Huey
2021-01-31 18:54 ` Yuxuan Shui
2021-01-31 20:10 ` Linus Torvalds [this message]
2021-01-31 20:20 ` Gabriel Krisman Bertazi
2021-01-31 21:21 ` Linus Torvalds
2021-01-31 21:30 ` Linus Torvalds
2021-01-31 22:04 ` Andy Lutomirski
2021-01-31 22:08 ` Kyle Huey
2021-01-31 22:20 ` Andy Lutomirski
2021-01-31 22:27 ` Kyle Huey
2021-01-31 23:17 ` Kyle Huey
2021-01-31 23:35 ` Linus Torvalds
2021-01-31 23:55 ` Linus Torvalds
2021-02-03 18:00 ` [PATCH] entry: Fix missed trap after single-step on system call return Gabriel Krisman Bertazi
2021-02-03 18:10 ` Linus Torvalds
2021-02-03 18:18 ` Andy Lutomirski
2021-02-03 18:22 ` Linus Torvalds
2021-02-03 18:11 ` Kyle Huey
2021-02-03 23:55 ` Kyle Huey
2021-02-04 17:46 ` Linus Torvalds
2021-02-05 23:24 ` [tip: core/urgent] entry: Ensure " tip-bot2 for Gabriel Krisman Bertazi
2021-01-31 22:57 ` [REGRESSION] x86/entry: TIF_SINGLESTEP handling is still broken Linus Torvalds
2021-01-31 23:36 ` Andy Lutomirski
2021-01-31 23:39 ` Kyle Huey
2021-01-31 23:40 ` Andy Lutomirski
2021-02-01 2:25 ` Robert O'Callahan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wixO7LJKwtD+CQJTQHgJFQjr=sSi_pQEGqcYdczTphncg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=rocallahan@gmail.com \
--cc=tglx@linutronix.de \
--cc=yshuiv7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.