All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kenneth Chan <kenneth.t.chan@gmail.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Harald Welte <laforge@gnumonks.org>
Subject: Re: [PATCH] add support for battery charging threshold, mute. correctly save ac/dc brightness to hardware registers
Date: Wed, 19 Aug 2020 10:50:12 +0300	[thread overview]
Message-ID: <CAHp75VdWhSTqCikgnF5vvgw5x96QV5MXBDOWnL4gWt+Z-QK0MQ@mail.gmail.com> (raw)
In-Reply-To: <20200818180223.14282-1-kenneth.t.chan@gmail.com>

On Tue, Aug 18, 2020 at 9:03 PM Kenneth Chan <kenneth.t.chan@gmail.com> wrote:
>

Thank you for a patch, but it misses few crucial points:
 - it should have good description as commit message (body of this letter)
 - it should have signature of origin (Signed-off-by tag) that I can
proceed (I see, it's in wrong position, use `git commit -s` to fix
this)
 - it should be split per one logical change in a patch, e.g. 1)
replacing ACPI prints by pr_*() macros, 2) split MODULE_AUTHOR() by
one author per macro call, 3) etc...


> Signed-off-by: Kenneth Chan <kenneth.t.chan@gmail.com>



-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2020-08-19  7:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 18:02 [PATCH] add support for battery charging threshold, mute. correctly save ac/dc brightness to hardware registers Kenneth Chan
2020-08-18 20:00 ` kernel test robot
2020-08-18 20:00   ` kernel test robot
2020-08-18 20:00   ` kernel test robot
2020-08-19  7:50 ` Andy Shevchenko [this message]
2020-08-19 22:31 ` kernel test robot
2020-08-19 22:31   ` kernel test robot
2020-08-19 22:31   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VdWhSTqCikgnF5vvgw5x96QV5MXBDOWnL4gWt+Z-QK0MQ@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=kenneth.t.chan@gmail.com \
    --cc=laforge@gnumonks.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.