Re: [v7 13/14] iio: imu: add BNO055 I2C driver

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andrea Merello <andrea.merello@iit.it>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Matt Ranostay <matt.ranostay@konsulko.com>,
	Alexandru Ardelean <ardeleanalex@gmail.com>,
	jmondi <jacopo@jmondi.org>,
	Andrea Merello <andrea.merello@gmail.com>,
	Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [v7 13/14] iio: imu: add BNO055 I2C driver
Date: Wed, 7 Sep 2022 17:09:26 +0300	[thread overview]
Message-ID: <CAHp75Vdc8bAiqiUhEmgjNmcpY5s0fArTy26g2i0wH7srwY6RQA@mail.gmail.com> (raw)
In-Reply-To: <20220907132205.28021-14-andrea.merello@iit.it>

On Wed, Sep 7, 2022 at 4:22 PM <andrea.merello@iit.it> wrote:
>
> From: Andrea Merello <andrea.merello@iit.it>
>
> Add an I2C driver for communicating to a BNO055 IMU via I2C bus and enable
> the BNO055 core driver to work in this scenario.
>
> Signed-off-by: Andrea Merello <andrea.merello@iit.it>

> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Hmm... It has my tag but I have noticed something to improve.

...

> +#define BNO055_I2C_XFER_BURST_BREAK_THRESHOLD 3 /* FIXME */

Can we elaborate what to fix and why it can't be fixed right now?

...

> +static const struct of_device_id __maybe_unused bno055_i2c_of_match[] = {
> +       { .compatible = "bosch,bno055" },

> +       { },

No comma for the terminator entry.

> +};

...

> +               .of_match_table = of_match_ptr(bno055_i2c_of_match),

No of_match_ptr(). This will disable ACPI support along with potential
compiler warning.

-- 
With Best Regards,
Andy Shevchenko