Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Steve Presser <steve@pressers.name>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Jeremy Cline <jeremy@jcline.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Jonathan Cameron <jic23@jic23.retrosnub.co.uk>,
	Lars Kellogg-Stedman <lars@oddbit.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200
Date: Tue, 30 Jan 2018 19:38:19 +0200	[thread overview]
Message-ID: <CAHp75VdsDAbgJ1XmhaxA5C8FTcYX7tBa4x_Y4ZYk6Sub510nqw@mail.gmail.com> (raw)
In-Reply-To: <CADXBfmvKF_doLv0Vg0TY4cH_rDBEP5NvJ4jHJf85iuOjJB6TzA@mail.gmail.com>

On Tue, Jan 30, 2018 at 7:25 PM, Steve Presser <steve@pressers.name> wrote:
> Andy,
>
> Where did the assertion the second device is a magnetometer come from? Just
> the data sheet?

Yep. See chapter 8.2. Isn't enough proof? Or you believe in two
accelerometers with off-by-one conflicting address on a cheap laptop
with left unused two magnetometers on the same time?

And we have a driver for magnetometer separately.

So, it looks like we need to move ACPI ID to a new "kinda I2C mfd" IIO
driver under drivers/iio/imu/bmc150_i2c.c

> Steve
>
>
> On Tue, Jan 30, 2018, 12:05 PM Andy Shevchenko <andy.shevchenko@gmail.com>
> wrote:
>>
>> On Tue, Jan 30, 2018 at 6:40 PM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>> > On Tue, Jan 30, 2018 at 6:01 PM, Jonathan Cameron
>> > <Jonathan.Cameron@huawei.com> wrote:
>> >> On Mon, 29 Jan 2018 16:07:02 +0200
>> >> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>> >
>> >>> > But that would take much longer.  Feel free to propose it and a
>> >>> > patch
>> >>> > removing the ifdef fun if you like!
>> >
>> >>> Where can I see the patch?
>> >
>> >> Doh. I clearly forgot to push out.  Should be able to push to
>> >> iio.git on kernel.org later.
>> >
>> > Thanks, I can see it now.
>> >
>> > This patch almost wrong. Not by functionality it brings, but by style.
>>
>> Oy vey, the second device is *not* accelerometer, it is a magnetometer
>> [1].
>>
>> [1]: https://www.mouser.com/ds/2/783/BST-BMC150-DS000-04-786477.pdf
>>
>> > I'll send soon a series of fixes to the driver (compile tested only)
>> > to provide my view on the matters.
>> >
>> > P.S. In the future (I have some kind of deja vu I have told this
>> > already to someone), please, Cc one or more of Rafael, Mika and/or me
>> > for ACPI matters.
>>
>> --
>> With Best Regards,
>> Andy Shevchenko

-- 
With Best Regards,
Andy Shevchenko