From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Mark Brown <broonie@kernel.org>, Lukas Wunner <lukas@wunner.de>,
Android Kernel Team <kernel-team@android.com>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] spi: Don't have controller clean up spi device before driver unbind
Date: Wed, 5 May 2021 20:53:14 +0300 [thread overview]
Message-ID: <CAHp75VeDzOZ_j30v=rgec2d9f6pPXHXE8BqJN1ARoYkfGL=d6g@mail.gmail.com> (raw)
In-Reply-To: <20210505164734.175546-1-saravanak@google.com>
On Wed, May 5, 2021 at 8:26 PM Saravana Kannan <saravanak@google.com> wrote:
>
> When a spi device is unregistered and triggers a driver unbind, the
> driver might need to access the spi device. So, don't have the
> controller clean up the spi device before the driver is unbound. Clean
> up the spi device after the driver is unbound.
>
> Fixes: c7299fea6769 ("spi: Fix spi device unregister flow")
> Reported-by: Lukas Wunner <lukas@wunner.de>
And
Suggested-by: Lukas ...
> Signed-off-by: Saravana Kannan <saravanak@google.com>
...
> Can you test this one your end to make sure you don't have issues
> anymore?
Do you need a test on my setup?
...
> + device_del(&spi->dev);
> + spi_cleanup(spi);
> + put_device(&spi->dev);
This block deserves a comment in the code.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-05 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 16:47 [PATCH v2] spi: Don't have controller clean up spi device before driver unbind Saravana Kannan
2021-05-05 17:53 ` Andy Shevchenko [this message]
2021-05-11 15:57 ` Mark Brown
2021-05-11 20:30 ` Andy Shevchenko
2021-05-14 15:22 ` Mark Brown
2021-05-21 5:09 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeDzOZ_j30v=rgec2d9f6pPXHXE8BqJN1ARoYkfGL=d6g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.