From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: David Jander <david@protonic.nl>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 03/11] spi: Lock controller idling transition inside the io_mutex
Date: Tue, 21 Jun 2022 15:36:23 +0200 [thread overview]
Message-ID: <CAHp75VeHcdcRMYxsJ3At+YyFZEauDPp-+deXbsBpcqKdxaicfg@mail.gmail.com> (raw)
In-Reply-To: <20220621061234.3626638-4-david@protonic.nl>
On Tue, Jun 21, 2022 at 8:15 AM David Jander <david@protonic.nl> wrote:
>
> This way, the spi sync path does not need to deal with the idling
> transition.
...
> - mutex_lock(&ctlr->io_mutex);
> ret = __spi_pump_transfer_message(ctlr, msg, was_busy);
> mutex_unlock(&ctlr->io_mutex);
>
> /* Prod the scheduler in case transfer_one() was busy waiting */
> if (!ret)
> cond_resched();
In the similar way
ret = ...
if (ret)
goto out_unlock;
mutex_unlock();
cond_resched();
return;
> + return;
> +
> +out_unlock:
> + mutex_unlock(&ctlr->io_mutex);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-21 13:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 6:12 [PATCH v3 00/11] Optimize spi_sync path David Jander
2022-06-21 6:12 ` [PATCH v3 01/11] spi: Move ctlr->cur_msg_prepared to struct spi_message David Jander
2022-06-21 6:12 ` [PATCH v3 02/11] spi: Don't use the message queue if possible in spi_sync David Jander
2022-06-21 6:12 ` [PATCH v3 03/11] spi: Lock controller idling transition inside the io_mutex David Jander
2022-06-21 13:36 ` Andy Shevchenko [this message]
2022-06-29 13:08 ` David Jander
2022-06-21 6:12 ` [PATCH v3 04/11] spi: __spi_pump_messages: Consolidate spin_unlocks to goto target David Jander
2022-06-21 6:12 ` [PATCH v3 05/11] spi: Remove check for controller idling in spi sync path David Jander
2022-06-21 6:12 ` [PATCH v3 06/11] spi: Remove check for idling in __spi_pump_messages() David Jander
2022-06-21 6:12 ` [PATCH v3 07/11] spi: Remove the now unused ctlr->idling flag David Jander
2022-06-21 6:12 ` [PATCH v3 08/11] spi: Remove unneeded READ_ONCE for ctlr->busy flag David Jander
2022-06-21 6:12 ` [PATCH v3 09/11] spi: Set ctlr->cur_msg also in the sync transfer case David Jander
2022-06-21 6:12 ` [PATCH v3 10/11] spi: Ensure the io_mutex is held until spi_finalize_current_message() David Jander
2022-06-21 13:41 ` Andy Shevchenko
2022-06-21 6:12 ` [PATCH v3 11/11] spi: opportunistically skip ctlr->cur_msg_completion David Jander
2022-06-21 13:46 ` Andy Shevchenko
2022-06-21 17:21 ` [PATCH v3 00/11] Optimize spi_sync path Mark Brown
2022-06-24 20:31 ` Mark Brown
2022-06-28 6:32 ` David Jander
2022-06-28 10:31 ` Mark Brown
2022-06-28 10:31 ` Mark Brown
2022-07-15 14:13 ` Thomas Kopp
2022-07-18 6:02 ` David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeHcdcRMYxsJ3At+YyFZEauDPp-+deXbsBpcqKdxaicfg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=david@protonic.nl \
--cc=linux-spi@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.