From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: peng.hao2@zte.com.cn
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
hutao@cn.fujitsu.com,
Linux Documentation List <linux-doc@vger.kernel.org>
Subject: Re: [PATCH V7 5/9] misc/pvpanic: add support to get pvpanic device info by FDT
Date: Mon, 5 Nov 2018 15:05:03 +0200 [thread overview]
Message-ID: <CAHp75VfZfBox+DVNU=JWLkD0ETHPca5tUfuh0srnEAU8M+q0Zg@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfP4d0fK9NDbAcHqy4aqTiMGTKBX5VQ36QbSyhRzrpOSQ@mail.gmail.com>
On Mon, Nov 5, 2018 at 2:58 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Nov 5, 2018 at 4:31 AM Peng Hao <peng.hao2@zte.com.cn> wrote:
> >
> > By default, when ACPI tables and FDT coexist for ARM64,
> > current kernel takes precedence over FDT to get device information.
> > Virt machine in qemu provides both FDT and ACPI table. Increases the
> > way to get information through FDT.
>
> > +#include <linux/acpi.h>
> > +#include <linux/init.h>
> > #include <linux/kernel.h>
> > #include <linux/module.h>
> > -#include <linux/init.h>
> > +#include <linux/of.h>
> > +#include <linux/of_address.h>
> > +#include <linux/platform_device.h>
> > #include <linux/types.h>
> > -#include <linux/acpi.h>
>
> Adding new headers in this change is okay, while shuffling them is
> logically a separate change.
Couple more remarks (regarding ping-pong style in this series):
1. The shuffling part should go after you remove init.h: no need to
shuffle the stuff you eventually remove.
2. When you introduce global variable for base, put it directly to the
place where it would be after your ifdef patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-05 13:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 10:40 [PATCH V7 1/9] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-11-05 10:40 ` [PATCH V7 2/9] misc/pvpanic: simplify the code using acpi_dev_resource_io Peng Hao
2018-11-05 10:40 ` [PATCH V7 3/9] misc/pvpanic: add MMIO support Peng Hao
2018-11-05 12:55 ` Andy Shevchenko
2018-11-05 10:40 ` [PATCH V7 4/9] dt-bindings: misc/pvpanic: add document for pvpanic-mmio Peng Hao
2018-11-05 10:40 ` [PATCH V7 5/9] misc/pvpanic: add support to get pvpanic device info by FDT Peng Hao
2018-11-05 12:58 ` Andy Shevchenko
2018-11-05 13:05 ` Andy Shevchenko [this message]
2018-11-05 10:40 ` [PATCH V7 6/9] misc/pvpanic : break dependency on ACPI Peng Hao
2018-11-05 13:00 ` Andy Shevchenko
2018-11-05 10:40 ` [PATCH V7 7/9] misc/pvpanic: remove unnecessary header file Peng Hao
2018-11-05 10:40 ` [PATCH V7 8/9] misc/pvpanic: convert to SPDX license tags Peng Hao
2018-11-05 10:40 ` [PATCH V7 9/9] misc/pvpanic: remove a redundant comma Peng Hao
2018-11-05 13:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfZfBox+DVNU=JWLkD0ETHPca5tUfuh0srnEAU8M+q0Zg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.hao2@zte.com.cn \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.