From: Andre Heider <a.heider@gmail.com>
To: Rick Macklem <rmacklem@uoguelph.ca>
Cc: Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org,
Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Re: [PATCH 1/2] NFSv4: Fix a regression against the FreeBSD server
Date: Sat, 20 Jul 2013 10:48:39 +0200 [thread overview]
Message-ID: <CAHsu+b84+RrqrZkEXjdd3-xCp0Cvs=U_e4mQHeuRyd+huUWwrA@mail.gmail.com> (raw)
In-Reply-To: <1774242197.1390191.1374190255822.JavaMail.root@uoguelph.ca>
On Fri, Jul 19, 2013 at 1:30 AM, Rick Macklem <rmacklem@uoguelph.ca> wrote:
> Andre Heider wrote:
>> On Wed, Jul 17, 2013 at 11:59 PM, Trond Myklebust
>> <Trond.Myklebust@netapp.com> wrote:
>> > Technically, the Linux client is allowed by the NFSv4 spec to send
>> > 3 word bitmaps as part of an OPEN request. However, this causes the
>> > current FreeBSD server to return NFS4ERR_ATTRNOTSUPP errors.
>> >
>> > Fix the regression by making the Linux client use a 2 word bitmap
>> > unless
>> > doing NFSv4.2 with labeled NFS.
>> >
>> > Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
>>
>> Tested-by: Andre Heider <a.heider@gmail.com>
>>
> I've attached the patch I plan to commit to FreeBSD's head soon, which
> fixes the server so that it checks for the high order bitmaps words
> being non-zero before replying with NFS4_ERR_ATTRNOTSUPP.
>
> The patch is pretty straightforward, but if you can apply it to your
> server and test it against the unpatched Linux client, that would be
> appreciated.
Confirmed, reverting the client patches and applying this server patch
also works ;)
Thanks,
Andre
prev parent reply other threads:[~2013-07-20 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 21:59 [PATCH 1/2] NFSv4: Fix a regression against the FreeBSD server Trond Myklebust
2013-07-17 21:59 ` [PATCH 2/2] NFSv4: encode_attrs should not backfill the bitmap and attribute length Trond Myklebust
2013-07-18 14:56 ` Andre Heider
2013-07-23 15:59 ` Andre Heider
2013-07-23 17:00 ` Myklebust, Trond
2013-07-23 17:30 ` Andre Heider
2013-07-23 20:14 ` Chuck Lever
2013-07-23 21:19 ` Myklebust, Trond
2013-07-23 21:22 ` Chuck Lever
2013-07-17 22:25 ` [PATCH 1/2] NFSv4: Fix a regression against the FreeBSD server Rick Macklem
2013-07-18 14:55 ` Andre Heider
2013-07-18 23:30 ` Rick Macklem
2013-07-18 23:48 ` Myklebust, Trond
2013-07-20 8:48 ` Andre Heider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHsu+b84+RrqrZkEXjdd3-xCp0Cvs=U_e4mQHeuRyd+huUWwrA@mail.gmail.com' \
--to=a.heider@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rmacklem@uoguelph.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.