Re: [PATCH v2 0/9] Various win32 fixes & teach 'getfd' QMP command to import sockets - Marc-André Lureau

From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Weil" <sw@weilnetz.de>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 0/9] Various win32 fixes & teach 'getfd' QMP command to import sockets
Date: Mon, 6 Feb 2023 10:36:25 +0400	[thread overview]
Message-ID: <CAJ+F1C+0FARQP-2q=Lc895aRoYdOOBbcYL_RXH=mVxY3V1b+NQ@mail.gmail.com> (raw)
In-Reply-To: <20230129182414.583349-1-marcandre.lureau@redhat.com>

Hi

On Sun, Jan 29, 2023 at 10:25 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> The following series first fixes a few tests on win32. The second part focuses
> on 'add_client' support, by limiting its scope to sockets and adding win32
> support. Finally, it enables vnc-display test on win32, to exercise the new code
> paths and demonstrate the usage.
>
> A follow up series will add dbus display support on win32, with tests using this
> socket import method.
>
> v2:
> - replce the propose new command in v1, with 'wsa-info' argument in 'getfd'
> - fix qapi/qmp for commands/events with optional arguments
> - rebase, and tags

ping

>
> Marc-André Lureau (9):
>   tests: fix path separator, use g_build_filename()
>   tests: fix test-io-channel-command on win32
>   tests/docker: fix a win32 error due to portability
>   osdep: implement qemu_socketpair() for win32
>   qmp: 'add_client' actually expects sockets
>   qapi: implement conditional command arguments
>   qmp: teach 'getfd' to import sockets on win32
>   libqtest: make qtest_qmp_add_client work on win32
>   qtest: enable vnc-display test on win32
>
>  qapi/misc.json                          |  16 +++-
>  include/qemu/sockets.h                  |   2 -
>  tests/qtest/libqtest.h                  |   2 -
>  monitor/hmp-cmds.c                      |   6 +-
>  monitor/misc.c                          |  75 ++++++++++++----
>  monitor/qmp-cmds.c                      |  13 ++-
>  tests/qtest/libqtest.c                  |  16 +++-
>  tests/qtest/vnc-display-test.c          |   5 --
>  tests/unit/test-io-channel-command.c    |   8 +-
>  util/oslib-win32.c                      | 110 ++++++++++++++++++++++++
>  scripts/qapi/commands.py                |   4 +
>  scripts/qapi/gen.py                     |  19 ++--
>  scripts/qapi/visit.py                   |   2 +
>  tests/docker/docker.py                  |   6 +-
>  tests/qapi-schema/qapi-schema-test.json |   3 +-
>  15 files changed, 245 insertions(+), 42 deletions(-)
>
> --
> 2.39.1
>
>


-- 
Marc-André Lureau