Re: [PATCH v6 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support - Marc-André Lureau

From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Doug Evans <dje@google.com>
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Jason Wang" <jasowang@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH v6 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support
Date: Thu, 13 May 2021 00:14:58 +0400	[thread overview]
Message-ID: <CAJ+F1C+VV9LzCuoiRevDiQ1zTmmsyfEbMGwuiD7gTN8fTYd8+A@mail.gmail.com> (raw)
In-Reply-To: <CADPb22SGrvWe5+Aonkwq1pcrBENMTMJetzR7WZN6zDkjxjGJNw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

Hi

On Wed, May 12, 2021 at 11:51 PM Doug Evans <dje@google.com> wrote:

>
> Btw, can you elaborate on "should rather be a diff of the commits that are
> new"?
> Up until now I've been told to provide "git shortlog old..new" output.
> The patch itself is just a one-liner to update the subproject sha1.
>

git modules used by qemu are usually tracking the master branch, so a
shortlog works fine and shows the additional comments. But when it's
switching branches, the shortlog doesn't provide the diff between the
branches, that is the commits that were not already in the branch being
tracked. In my last update (
https://patchew.org/QEMU/20210125073427.3970606-1-marcandre.lureau@redhat.com/20210125073427.3970606-2-marcandre.lureau@redhat.com/),
I used a tool called git-cherry-diff, but there might be git log arguments
to do that I ignore.

-- 
Marc-André Lureau

[-- Attachment #2: Type: text/html, Size: 1601 bytes --]