All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can: mcp251x: fix support for half duplex SPI host controllers
Date: Tue, 30 Mar 2021 14:06:03 -0700	[thread overview]
Message-ID: <CAJ+vNU0w2faqmW0MOA9FQD8=vxpJH1Lc8c0BMcAVKGNq1vNjjg@mail.gmail.com> (raw)
In-Reply-To: <20210330100246.1074375-1-mkl@pengutronix.de>

On Tue, Mar 30, 2021 at 3:02 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> Some SPI host controllers do not support full-duplex SPI transfers.
>
> The function mcp251x_spi_trans() does a full duplex transfer. It is
> used in several places in the driver, where a TX half duplex transfer
> is sufficient.
>
> To fix support for half duplex SPI host controllers, this patch
> introduces a new function mcp251x_spi_write() and changes all callers
> that do a TX half duplex transfer to use mcp251x_spi_write().
>
> Fixes: e0e25001d088 ("can: mcp251x: add support for half duplex controllers")
> Cc: Tim Harvey <tharvey@gateworks.com>
> Reported-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---

Mi Marc and Gerhard,

So was the issue being resolved here that there was another SPI host
controller that wasn't advertising that it was half duplex only or was
something else wrong with e0e25001d088 ("can: mcp251x: add support for
half duplex controllers")?

Best regards,

Tim

  reply	other threads:[~2021-03-30 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 10:02 [PATCH] can: mcp251x: fix support for half duplex SPI host controllers Marc Kleine-Budde
2021-03-30 21:06 ` Tim Harvey [this message]
2021-03-31  7:14   ` Marc Kleine-Budde
2021-03-31 13:45     ` Gerhard Bertelsmann
2021-03-31 14:54     ` Tim Harvey
2021-03-31 15:05       ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ+vNU0w2faqmW0MOA9FQD8=vxpJH1Lc8c0BMcAVKGNq1vNjjg@mail.gmail.com' \
    --to=tharvey@gateworks.com \
    --cc=info@gerhard-bertelsmann.de \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.