Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support

From: razvan becheriu <razvan.becheriu@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Razvan Becheriu <razvan.becheriu@qualitance.com>,
	linux-watchdog@vger.kernel.org,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>, Ferry Toth <fntoth@gmail.com>
Subject: Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
Date: Wed, 2 Oct 2019 09:11:33 +0300	[thread overview]
Message-ID: <CAJAoKi_C85WDxu_XppFhn7BjZC1GznqQrPFKW9W2wEpHzz4wPw@mail.gmail.com> (raw)
In-Reply-To: <CAJAoKi_c2XRi_tdJcc3MMS1=9d4WH_Tq9EmH30-GyXcPoJhXGA@mail.gmail.com>

Hi,

regarding the test for the WATCHDOG_NOWAYOUT patch:

```
Tested-by: Razvan Becheriu <razvan.becheriu@gmail.com>
The patch works.
By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping
the watchdog.service, the board reboots.
Previously, the watchdog.service was able to disable the watchdog
counter, and no reboot was performed.
```

Thank you,
Razvan

On Tue, Oct 1, 2019 at 10:06 PM razvan becheriu
<razvan.becheriu@gmail.com> wrote:
>
> Hi,
>
> regarding the test for the WATCHDOG_NOWAYOUT patch:
>
> ...
> Tested-by: Razvan Becheriu <razvan.becheriu@gmail.com>
> The patch works.
> By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping the watchdog.service, the board reboots.
> Previously, the watchdog.service was able to disable the watchdog counter, and no reboot was performed.
> ...
>
> Thank you,
> Razvan
>
> On Tue, Sep 24, 2019 at 6:13 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>>
>> Normally, the watchdog is disabled when /dev/watchdog is closed, but if
>> CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog should
>> remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT
>> is defined.
>>
>> Reported-by: Razvan Becheriu <razvan.becheriu@qualitance.com>
>> Cc: Ferry Toth <fntoth@gmail.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>  drivers/watchdog/intel-mid_wdt.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
>> index 2cdbd37c700c..470213abfd3d 100644
>> --- a/drivers/watchdog/intel-mid_wdt.c
>> +++ b/drivers/watchdog/intel-mid_wdt.c
>> @@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
>>         wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT;
>>         wdt_dev->parent = dev;
>>
>> +       watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT);
>>         watchdog_set_drvdata(wdt_dev, dev);
>>
>>         ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
>> --
>> 2.23.0
>>