From: Michael Platings <michael@platin.gs>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Jacob Keller" <jacob.keller@gmail.com>,
"Jeff King" <peff@peff.net>, "Barret Rhoden" <brho@google.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Git mailing list" <git@vger.kernel.org>,
"Stefan Beller" <stefanbeller@gmail.com>,
"Jeff Smith" <whydoubt@gmail.com>, "René Scharfe" <l.s.r@web.de>
Subject: Re: [RFC PATCH 0/1] Fuzzy blame
Date: Wed, 27 Mar 2019 08:26:00 +0000 [thread overview]
Message-ID: <CAJDYR9T40xaSpmL_e00WWXzxEm_j0pcTqBhvr=5mu-fTpKodmQ@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8D8yBK9p9Rgy+wk8cMfPLG7qanvGA-LcmmHmjbaMnvBLQ@mail.gmail.com>
> Another good place to keep these revs is git-notes,
> which probably could result in faster lookups too and can be made
> visible in git-log.
Oh wow, I really like this. A major concern I had about the revisions
file was that you don't know what a revision ID will be until it's
upstream. If you can specify *in the commit message itself* what
options should apply to git blame for that revision then that problem
is solved. And if you change your mind later, or want to ignore a
pre-existing revision then git-notes solves that problem.
So I'm thinking you just have a commit message like this:
"
Make all function names snake_case
git-blame-ignore: fuzzy
"
And users who have blame.ignoreRevs set will have the -F/--fuzzy
option applied to that commit.
> But that's in addition to --ignoreRevsFile, not replacing it.
I disagree. ignoreRevsFile has the major problem that the file will
need updating every time you rebase a commit to be ignored, and you'll
need to remember to edit it for cherry picks. Let's not have that
option as I think it will add unhelpful complexity.
-Michael
next prev parent reply other threads:[~2019-03-27 8:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 23:50 [RFC PATCH 0/1] Fuzzy blame michael
2019-03-24 23:50 ` [RFC PATCH 1/1] " michael
2019-03-25 2:39 ` [RFC PATCH 0/1] " Junio C Hamano
2019-03-25 9:32 ` Michael Platings
2019-03-25 16:04 ` Barret Rhoden
2019-03-25 23:21 ` Michael Platings
2019-03-25 23:35 ` Jeff King
2019-03-26 3:07 ` Jacob Keller
2019-03-26 20:26 ` Michael Platings
2019-03-27 6:36 ` Duy Nguyen
2019-03-27 8:26 ` Michael Platings [this message]
2019-03-27 9:02 ` Duy Nguyen
2019-04-03 15:25 ` Barret Rhoden
2019-04-03 21:49 ` Michael Platings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJDYR9T40xaSpmL_e00WWXzxEm_j0pcTqBhvr=5mu-fTpKodmQ@mail.gmail.com' \
--to=michael@platin.gs \
--cc=brho@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=stefanbeller@gmail.com \
--cc=whydoubt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.