From: Salvatore Mesoraca <s.mesoraca16@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Ingo Molnar <mingo@redhat.com>, Kees Cook <keescook@chromium.org>
Subject: Re: [v2] ftrace: drop a VLA in module_exists()
Date: Sat, 31 Mar 2018 11:55:16 +0200 [thread overview]
Message-ID: <CAJHCu1+9NJ0onfjETfwn+XSL_d1Zxo0P=5RpWUkxnXO597BA5g@mail.gmail.com> (raw)
In-Reply-To: <20180330103411.5ed25f43@gandalf.local.home>
2018-03-30 16:34 GMT+02:00 Steven Rostedt <rostedt@goodmis.org>:
> On Fri, 30 Mar 2018 10:53:08 +0200
> Salvatore Mesoraca <s.mesoraca16@gmail.com> wrote:
>
> Couple of things. First, "PATCH" was dropped from the subject. If my
> inbox was busy today, I probably would have missed this email.
Aargh, I'm sorry for this, I didn't notice it.
>> Avoid a VLA[1] by using a real constant expression instead of a variable.
>> The compiler should be able to optimize the original code and avoid using
>> an actual VLA. Anyway this change is useful because it will avoid a false
>> positive with -Wvla, it might also help the compiler generating better
>> code.
>>
>> [1] https://lkml.org/lkml/2018/3/7/621
>
> Second, do not use lkml.org, use http://lkml.kernel.org/r/<messageid>
>
> Search for "Link:" tags in git log to see examples.
Thank you for the suggestion.
> Other than that, the patch looks fine to me and I can pull it for the
> next merge window.
Thank you very much,
Salvatore
prev parent reply other threads:[~2018-03-31 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 8:53 [v2] ftrace: drop a VLA in module_exists() Salvatore Mesoraca
2018-03-30 14:34 ` Steven Rostedt
2018-03-31 9:55 ` Salvatore Mesoraca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJHCu1+9NJ0onfjETfwn+XSL_d1Zxo0P=5RpWUkxnXO597BA5g@mail.gmail.com' \
--to=s.mesoraca16@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.