Re: [PATCH] cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode

From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Doug Smythies <dsmythies@telus.net>
Cc: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>,
	Len Brown <lenb@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"M. Cagri Ari" <cagriari@pm.me>
Subject: Re: [PATCH] cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode
Date: Sat, 10 Sep 2022 18:42:01 +0200	[thread overview]
Message-ID: <CAJZ5v0hgw+1AEm6kZhMGgPBzPXr_fWZV_ViJScF4GDejrE2rYw@mail.gmail.com> (raw)
In-Reply-To: <003c01d8c22f$4a8e2270$dfaa6750$@telus.net>

On Tue, Sep 6, 2022 at 10:29 PM Doug Smythies <dsmythies@telus.net> wrote:
>
> Users may disable HWP in firmware, in which case intel_pstate wouldn't load
> unless the CPU model is explicitly supported.
>
> Add TIGERLAKE to the list of CPUs that can register intel_pstate while not
> advertising the HWP capability. Without this change, an TIGERLAKE in no-HWP
> mode could only use the acpi_cpufreq frequency scaling driver.
>
> See also commits:
> d8de7a44e11f: cpufreq: intel_pstate: Add Skylake servers support
> fbdc21e9b038: cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode
> 706c5328851d: cpufreq: intel_pstate: Add Cometlake support in no-HWP mode
>
> Reported by: M. Cargi Ari <cagriari@pm.me>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 57cdb3679885..fc3ebeb0bbe5 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2416,6 +2416,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
>         X86_MATCH(SKYLAKE_X,            core_funcs),
>         X86_MATCH(COMETLAKE,            core_funcs),
>         X86_MATCH(ICELAKE_X,            core_funcs),
> +       X86_MATCH(TIGERLAKE,            core_funcs),
>         {}
>  };
>  MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> --

Applied as 6.1 material, thanks!