Re: [PATCH v1 1/2] Revert "PM: runtime: Update device status before letting suppliers suspend"

From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	"elaine.zhang" <zhangqing@rock-chips.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] Revert "PM: runtime: Update device status before letting suppliers suspend"
Date: Fri, 19 Mar 2021 14:43:42 +0100	[thread overview]
Message-ID: <CAJZ5v0iCSrN0Nf=2zfz=9GJKip8JY4MH1_kMS1A_MX3qmeZVDw@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFpU45vQMB_gdGnodV1=-fORJgtG3VXpeLaKvw4p5vMZhQ@mail.gmail.com>

On Fri, Mar 19, 2021 at 2:31 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Thu, 18 Mar 2021 at 19:15, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> >
> > Revert commit 44cc89f76464 ("PM: runtime: Update device status
> > before letting suppliers suspend") that introduced a race condition
> > into __rpm_callback() which allowed a concurrent rpm_resume() to
> > run and resume the device prematurely after its status had been
> > changed to RPM_SUSPENDED by __rpm_callback().
>
> Huh, the code path is not entirely easy to follow. :-)
>
> Did you find this by code inspection or did you get an error report?

There was a bug report that caused me to look at the code once again.

> > Fixes: 44cc89f76464 ("PM: runtime: Update device status before letting suppliers suspend")
> > Link: https://lore.kernel.org/linux-pm/24dfb6fc-5d54-6ee2-9195-26428b7ecf8a@intel.com/
> > Reported by: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: 4.10+ <stable@vger.kernel.org> # 4.10+
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Thanks!