From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Maximilian Luz <luzmaximilian@gmail.com>,
Dawei Li <set_pte_at@outlook.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
u.kleine-koenig@pengutronix.de, dvhart@infradead.org,
andy@infradead.org, lenb@kernel.org, arnd@arndb.de,
peterhuewe@gmx.de, kys@microsoft.com, kronos.it@gmail.com,
dmitry.torokhov@gmail.com, bleung@chromium.org,
sujith.thomas@intel.com, vithampi@vmware.com, lee@kernel.org,
wim@linux-watchdog.org, jgross@suse.com, davem@davemloft.net,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2] ACPI: make remove callback of ACPI driver void
Date: Wed, 23 Nov 2022 19:29:17 +0100 [thread overview]
Message-ID: <CAJZ5v0jwY-cH1F3iJzGakzQG7v-ex7_-AC3cm6tUkfTd81_srw@mail.gmail.com> (raw)
In-Reply-To: <e78ddf03-b67e-a045-cd72-f0edbc586cb2@gmail.com>
On Tue, Nov 15, 2022 at 10:00 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>
> On 11/13/22 17:26, Dawei Li wrote:
> > For bus-based driver, device removal is implemented as:
> > 1 device_remove()->
> > 2 bus->remove()->
> > 3 driver->remove()
> >
> > Driver core needs no inform from callee(bus driver) about the
> > result of remove callback. In that case, commit fc7a6209d571
> > ("bus: Make remove callback return void") forces bus_type::remove
> > be void-returned.
> >
> > Now we have the situation that both 1 & 2 of calling chain are
> > void-returned, so it does not make much sense for 3(driver->remove)
> > to return non-void to its caller.
> >
> > So the basic idea behind this change is making remove() callback of
> > any bus-based driver to be void-returned.
> >
> > This change, for itself, is for device drivers based on acpi-bus.
> >
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Acked-by: Lee Jones <lee@kernel.org>
> > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > Signed-off-by: Dawei Li <set_pte_at@outlook.com>
>
> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for drivers/platform/surface/*
Applied as 6.2 material, thanks!
prev parent reply other threads:[~2022-11-23 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 16:26 [PATCH v2] ACPI: make remove callback of ACPI driver void Dawei Li
2022-11-15 21:00 ` Maximilian Luz
2022-11-23 18:29 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jwY-cH1F3iJzGakzQG7v-ex7_-AC3cm6tUkfTd81_srw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=bleung@chromium.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jgross@suse.com \
--cc=kronos.it@gmail.com \
--cc=kys@microsoft.com \
--cc=lee@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=platform-driver-x86@vger.kernel.org \
--cc=set_pte_at@outlook.com \
--cc=sujith.thomas@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vithampi@vmware.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.