From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: Jason Zaman <jason@perfinion.com>, selinux <selinux@tycho.nsa.gov>
Subject: Re: [PATCH] travis.yml: add ruby 2.5 to the test matrix
Date: Mon, 21 May 2018 22:42:15 +0200 [thread overview]
Message-ID: <CAJfZ7=n8RCbOXyLNwongX_Og2hEsogrpVFF=GWKv8B5z-DpYmw@mail.gmail.com> (raw)
In-Reply-To: <20180521100346.48699-1-jason@perfinion.com>
On Mon, May 21, 2018 at 12:03 PM, Jason Zaman <jason@perfinion.com> wrote:
>
> Ruby 2.5 is not installed by default, force reinstall with rvm
>
> Signed-off-by: Jason Zaman <jason@perfinion.com>
> ---
>
> This passes on my repo:
> https://travis-ci.org/perfinion/selinux/builds/381597252
This passes on my repo too, both without any modifications compared to
upstream and with some modifications to Makefiles (I enabled more
warning flags in my repo, like clang -Weverything, but they trigger
some false positive depending on the compiler version, which is why I
do not upstream these modifications). For the record, clang did not
like the "__error__" attribute used by some Ruby headers (cf.
https://travis-ci.org/fishilico/selinux/builds/381760812) and this is
not an issue related to the project.
Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Thanks,
Nicolas
next prev parent reply other threads:[~2018-05-21 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 10:03 [PATCH] travis.yml: add ruby 2.5 to the test matrix Jason Zaman
2018-05-21 20:42 ` Nicolas Iooss [this message]
2018-05-22 15:39 ` Jason Zaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfZ7=n8RCbOXyLNwongX_Og2hEsogrpVFF=GWKv8B5z-DpYmw@mail.gmail.com' \
--to=nicolas.iooss@m4x.org \
--cc=jason@perfinion.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.