From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
Yang Xu <xuyang2018.jy@fujitsu.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Filipe Manana <fdmanana@kernel.org>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] ovl: remove privs in ovl_fallocate()
Date: Wed, 5 Oct 2022 16:40:10 +0200 [thread overview]
Message-ID: <CAJfpeguiGqdSZVwsx_MrLd2MLvLMAkz58NjCMHZehpWZCK5fFw@mail.gmail.com> (raw)
In-Reply-To: <20221003123040.900827-3-amir73il@gmail.com>
On Mon, 3 Oct 2022 at 14:30, Amir Goldstein <amir73il@gmail.com> wrote:
>
> Underlying fs doesn't remove privs because fallocate is called with
> privileged mounter credentials.
>
> This fixes some failure in fstests generic/683..687.
>
> Fixes: aab8848cee5e ("ovl: add ovl_fallocate()")
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Acked-by: Miklos Szeredi <mszeredi@redhat.com>
Christian, please feel free to take these if you already have a bunch
of related patches.
Thanks,
Miklos
next prev parent reply other threads:[~2022-10-05 14:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 12:30 [PATCH 0/2] Some fixes for overlayfs remove privs Amir Goldstein
2022-10-03 12:30 ` [PATCH 1/2] ovl: remove privs in ovl_copyfile() Amir Goldstein
2022-10-05 14:37 ` Miklos Szeredi
2022-10-03 12:30 ` [PATCH 2/2] ovl: remove privs in ovl_fallocate() Amir Goldstein
2022-10-04 10:59 ` Christian Brauner
2022-10-04 13:20 ` Christian Brauner
2022-10-04 14:01 ` Amir Goldstein
2022-10-04 14:12 ` Christian Brauner
2022-10-04 15:52 ` Christian Brauner
2022-10-05 13:56 ` Amir Goldstein
2022-10-05 14:40 ` Miklos Szeredi [this message]
2022-10-05 15:16 ` Christian Brauner
-- strict thread matches above, loose matches on Subject: below --
2022-10-03 12:21 [PATCH 0/2] Some fixes for overlayfs remove privs Amir Goldstein
2022-10-03 12:21 ` [PATCH 2/2] ovl: remove privs in ovl_fallocate() Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpeguiGqdSZVwsx_MrLd2MLvLMAkz58NjCMHZehpWZCK5fFw@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=fdmanana@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.